<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117524/">https://git.reviewboard.kde.org/r/117524/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Cruceru Calin-Cristian.</div>
<p style="color: grey;"><i>Updated April 25, 2014, 9:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=333244">333244</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added operator== and operator!= to the class GeoDataModel and its related classes GeoDataScale, GeoDataOrientation, GeoDataLocation and GeoDataResourceMap. Extended TestEquality by a new unit test method for each class which verifies the implementation for several instances of each class.
Although it was not the purpose of this patch, I also added a "using GeoDataObject::equals" in GeoDataOverlay.h (to avoid the warnings which said that GeoDataObject::equals was hidden by GeoDataOverlay::equals) and also called GeoDataObject::equals(other) in GeoDataOverlay::equals.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested using tests/TestEquality and works fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/geodata/data/GeoDataLocation.h <span style="color: grey">(1e59597)</span></li>
<li>src/lib/marble/geodata/data/GeoDataLocation.cpp <span style="color: grey">(d0d4b18)</span></li>
<li>src/lib/marble/geodata/data/GeoDataModel.h <span style="color: grey">(031032a)</span></li>
<li>src/lib/marble/geodata/data/GeoDataModel.cpp <span style="color: grey">(b7fee49)</span></li>
<li>src/lib/marble/geodata/data/GeoDataOrientation.h <span style="color: grey">(4546c00)</span></li>
<li>src/lib/marble/geodata/data/GeoDataOrientation.cpp <span style="color: grey">(935b027)</span></li>
<li>src/lib/marble/geodata/data/GeoDataOverlay.h <span style="color: grey">(aeaae16)</span></li>
<li>src/lib/marble/geodata/data/GeoDataOverlay.cpp <span style="color: grey">(8a8c492)</span></li>
<li>src/lib/marble/geodata/data/GeoDataResourceMap.h <span style="color: grey">(e6fc407)</span></li>
<li>src/lib/marble/geodata/data/GeoDataResourceMap.cpp <span style="color: grey">(2beb074)</span></li>
<li>src/lib/marble/geodata/data/GeoDataScale.h <span style="color: grey">(0c88fa8)</span></li>
<li>src/lib/marble/geodata/data/GeoDataScale.cpp <span style="color: grey">(05db6b4)</span></li>
<li>tests/TestEquality.cpp <span style="color: grey">(02bd179)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117524/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>