[Marble-devel] Review Request 117188: Added support for kml tag SchemaData and SimpleData

[Abhinav Gangwar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117188/
-----------------------------------------------------------

(Updated April 11, 2014, 2:30 a.m.)


Review request for Marble.


Changes
-------

1. Added equality operator for GeoDataSchemaData and GeoDataSimpleData. Also added unit tests in TestEquality to test the same.


Repository: marble


Description
-------

Added support for kml tag SchemaData and its child element SimpleData.


Diffs (updated)
-----

  src/lib/marble/geodata/CMakeLists.txt 0ec3c3b 
  src/lib/marble/geodata/data/GeoDataExtendedData.h 37f76fb 
  src/lib/marble/geodata/data/GeoDataExtendedData.cpp 219aab4 
  src/lib/marble/geodata/data/GeoDataExtendedData_p.h 99cfc0d 
  src/lib/marble/geodata/data/GeoDataSchema.cpp 3eabe89 
  src/lib/marble/geodata/data/GeoDataSchemaData.h PRE-CREATION 
  src/lib/marble/geodata/data/GeoDataSchemaData.cpp PRE-CREATION 
  src/lib/marble/geodata/data/GeoDataSimpleData.h PRE-CREATION 
  src/lib/marble/geodata/data/GeoDataSimpleData.cpp PRE-CREATION 
  src/lib/marble/geodata/handlers/kml/KmlElementDictionary.h 01d8ad0 
  src/lib/marble/geodata/handlers/kml/KmlElementDictionary.cpp d8dfa76 
  src/lib/marble/geodata/handlers/kml/KmlSchemaDataTagHandler.cpp a81c49f 
  src/lib/marble/geodata/handlers/kml/KmlSimpleDataTagHandler.h PRE-CREATION 
  src/lib/marble/geodata/handlers/kml/KmlSimpleDataTagHandler.cpp PRE-CREATION 
  src/lib/marble/geodata/parser/GeoDataTypes.h dafcea3 
  src/lib/marble/geodata/parser/GeoDataTypes.cpp e87b876 
  src/lib/marble/geodata/writers/kml/KmlExtendedDataTagWriter.cpp ba77509 
  src/lib/marble/geodata/writers/kml/KmlSchemaDataTagWriter.h PRE-CREATION 
  src/lib/marble/geodata/writers/kml/KmlSchemaDataTagWriter.cpp PRE-CREATION 
  src/lib/marble/geodata/writers/kml/KmlSchemaTagWriter.h 89532b5 
  src/lib/marble/geodata/writers/kml/KmlSchemaTagWriter.cpp 64bf3ca 
  src/lib/marble/geodata/writers/kml/KmlSimpleDataTagWriter.h PRE-CREATION 
  src/lib/marble/geodata/writers/kml/KmlSimpleDataTagWriter.cpp PRE-CREATION 
  src/lib/marble/geodata/writers/kml/KmlSimpleFieldTagWriter.h d830050 
  tests/TestEquality.cpp 02bd179 
  tests/data/schemaData.kml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/117188/diff/


Testing
-------

Works fine on my system


Thanks,

Abhinav Gangwar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140410/e25ec10a/attachment.html>