<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117188/">https://git.reviewboard.kde.org/r/117188/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Abhinav Gangwar.</div>
<p style="color: grey;"><i>Updated April 11, 2014, 2:30 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. Added equality operator for GeoDataSchemaData and GeoDataSimpleData. Also added unit tests in TestEquality to test the same.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added support for kml tag SchemaData and its child element SimpleData.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works fine on my system</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/geodata/CMakeLists.txt <span style="color: grey">(0ec3c3b)</span></li>
<li>src/lib/marble/geodata/data/GeoDataExtendedData.h <span style="color: grey">(37f76fb)</span></li>
<li>src/lib/marble/geodata/data/GeoDataExtendedData.cpp <span style="color: grey">(219aab4)</span></li>
<li>src/lib/marble/geodata/data/GeoDataExtendedData_p.h <span style="color: grey">(99cfc0d)</span></li>
<li>src/lib/marble/geodata/data/GeoDataSchema.cpp <span style="color: grey">(3eabe89)</span></li>
<li>src/lib/marble/geodata/data/GeoDataSchemaData.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/data/GeoDataSchemaData.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/data/GeoDataSimpleData.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/data/GeoDataSimpleData.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlElementDictionary.h <span style="color: grey">(01d8ad0)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlElementDictionary.cpp <span style="color: grey">(d8dfa76)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlSchemaDataTagHandler.cpp <span style="color: grey">(a81c49f)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlSimpleDataTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlSimpleDataTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/parser/GeoDataTypes.h <span style="color: grey">(dafcea3)</span></li>
<li>src/lib/marble/geodata/parser/GeoDataTypes.cpp <span style="color: grey">(e87b876)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlExtendedDataTagWriter.cpp <span style="color: grey">(ba77509)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlSchemaDataTagWriter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlSchemaDataTagWriter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlSchemaTagWriter.h <span style="color: grey">(89532b5)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlSchemaTagWriter.cpp <span style="color: grey">(64bf3ca)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlSimpleDataTagWriter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlSimpleDataTagWriter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlSimpleFieldTagWriter.h <span style="color: grey">(d830050)</span></li>
<li>tests/TestEquality.cpp <span style="color: grey">(02bd179)</span></li>
<li>tests/data/schemaData.kml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117188/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>