[Marble-devel] Review Request 117390: Added more installed header files and tried to reduce exposition of cloudsync headers

[Dennis Nienhüser]

> On April 6, 2014, 7:53 a.m., Dennis Nienhüser wrote:
> > Thanks, looks good. I'd like to avoid installing the CloudSyncManager header at this point, however. To make that possible I pushed http://commits.kde.org/marble/087097b10911914ebad1648775f282cfdbc60bb5 which removes the enum from the signal. Can you test whether that gets rid of the need of an installed CloudSyncManager.h?
> >
> 
> Philippe Renon wrote:
>     With your change things are better but I still need CloudSyncManager.h to be installed.
>     Problem is with QtMarbleConfigDialog constructor that now takes a CloudSyncManager.
>     We use and instantiate QtMarbleConfigDialog in our application and passing a null CloudSyncManager is not supported.

I tried supporting that with http://commits.kde.org/marble/ca4176d
Can you give it a try, please?


- Dennis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117390/#review55050
-----------------------------------------------------------


On April 5, 2014, 4:06 p.m., Philippe Renon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117390/
> -----------------------------------------------------------
> 
> (Updated April 5, 2014, 4:06 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch adds more installed headers files.
> It addresses the issues described here : http://forum.kde.org/viewtopic.php?f=217&t=120442
> 
> I have tried to remove some cloudsync/*.h includes to avoid exposing them.
> I did this by forward declaring cloudsync classes in a few places.
> 
> Unfortunately, in one critical file, namely QtMarbleConfigDialog, it was not possible to forward declare a cloudsync class.
> And this because, a method was added that references a cloudsync enum and enums cannot be forward declared (at least with with current C++ version).
> 
> 
> Diffs
> -----
> 
>   src/apps/marble-qt/CMakeLists.txt 432d056 
>   src/apps/marble-qt/QtMainWindow.cpp 221cbc7 
>   src/apps/marble-ui/CMakeLists.txt c56c51a 
>   src/apps/marble-ui/ControlView.cpp cf69c5e 
>   src/lib/marble/CMakeLists.txt bb6f312 
>   src/lib/marble/QtMarbleConfigDialog.h d710a96 
>   src/lib/marble/cloudsync/CloudSyncManager.h cafdad3 
>   src/lib/marble/cloudsync/CloudSyncManager.cpp 463c38e 
>   src/lib/marble/cloudsync/RouteSyncManager.h 46e9526 
>   src/lib/marble/cloudsync/RouteSyncManager.cpp 4f0631b 
> 
> Diff: https://git.reviewboard.kde.org/r/117390/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Philippe Renon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140409/804ae2b1/attachment.html>