<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117390/">https://git.reviewboard.kde.org/r/117390/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 6th, 2014, 7:53 a.m. UTC, <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks, looks good. I'd like to avoid installing the CloudSyncManager header at this point, however. To make that possible I pushed http://commits.kde.org/marble/087097b10911914ebad1648775f282cfdbc60bb5 which removes the enum from the signal. Can you test whether that gets rid of the need of an installed CloudSyncManager.h?
</pre>
</blockquote>
<p>On April 6th, 2014, 9:16 p.m. UTC, <b>Philippe Renon</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">With your change things are better but I still need CloudSyncManager.h to be installed.
Problem is with QtMarbleConfigDialog constructor that now takes a CloudSyncManager.
We use and instantiate QtMarbleConfigDialog in our application and passing a null CloudSyncManager is not supported.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tried supporting that with http://commits.kde.org/marble/ca4176d
Can you give it a try, please?
</pre>
<br />
<p>- Dennis</p>
<br />
<p>On April 5th, 2014, 4:06 p.m. UTC, Philippe Renon wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Philippe Renon.</div>
<p style="color: grey;"><i>Updated April 5, 2014, 4:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds more installed headers files.
It addresses the issues described here : http://forum.kde.org/viewtopic.php?f=217&t=120442
I have tried to remove some cloudsync/*.h includes to avoid exposing them.
I did this by forward declaring cloudsync classes in a few places.
Unfortunately, in one critical file, namely QtMarbleConfigDialog, it was not possible to forward declare a cloudsync class.
And this because, a method was added that references a cloudsync enum and enums cannot be forward declared (at least with with current C++ version).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/apps/marble-qt/CMakeLists.txt <span style="color: grey">(432d056)</span></li>
<li>src/apps/marble-qt/QtMainWindow.cpp <span style="color: grey">(221cbc7)</span></li>
<li>src/apps/marble-ui/CMakeLists.txt <span style="color: grey">(c56c51a)</span></li>
<li>src/apps/marble-ui/ControlView.cpp <span style="color: grey">(cf69c5e)</span></li>
<li>src/lib/marble/CMakeLists.txt <span style="color: grey">(bb6f312)</span></li>
<li>src/lib/marble/QtMarbleConfigDialog.h <span style="color: grey">(d710a96)</span></li>
<li>src/lib/marble/cloudsync/CloudSyncManager.h <span style="color: grey">(cafdad3)</span></li>
<li>src/lib/marble/cloudsync/CloudSyncManager.cpp <span style="color: grey">(463c38e)</span></li>
<li>src/lib/marble/cloudsync/RouteSyncManager.h <span style="color: grey">(46e9526)</span></li>
<li>src/lib/marble/cloudsync/RouteSyncManager.cpp <span style="color: grey">(4f0631b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117390/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>