[Marble-devel] Review Request 113201: Added a new option - JUSTLIB - in CMakeLists.txt for OS X which, when enabled, just installs the development files and libmarblewidget.dylib

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113201/#review42183
-----------------------------------------------------------


Generally I like the Mac package to become a library that developers can use. I am a bit concerned that the patch introduces another option for it though, which complicates the overcomplicated cmake files even more.

I don't know much about Mac packaging. Is it possible to split up the compilation/installation part and the actual packaging part like done in Linux and Windows? Then just install everything and pick whatever you like for the package that is being created. So I'd suggest not to add a JUSTLIB option, and instead do the "positive" changes it introduces always (e.g. installing headers). And please don't do it by duplicating all of them, just remove the if (APPLE AND QTONLY) check that currently prevents installing headers. For the "negative" changes, i.e. preventing to build applications, I'd argument the same way: Just compile/install them, and do not include them in a library package.


- Dennis Nienhüser


On Oct. 11, 2013, 11:26 a.m., Mohammed Nafees wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113201/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2013, 11:26 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Previously, using libmarblewidget on OS X was not a very easy task. It had its ups and downs not allowing developers to fully utilise the power of libmarblewidget on OS X. This patch will help developers use libmarblewidget in their OS X apps as well. It has a same structure as in Linux. So, the same code can be compiled on OS X and Linux. This takes Marble a step further into the Mac arena ;)
> 
> 
> Diffs
> -----
> 
>   src/routing-instructions/CMakeLists.txt 531516d 
>   src/mac/Contents/Resources/CMakeLists.txt 3d64414 
>   src/CMakeLists.txt 7f54f85 
>   src/lib/CMakeLists.txt 4f2eee1 
>   CMakeLists.txt a740667 
>   MarbleMacros.cmake 694c4a7 
> 
> Diff: http://git.reviewboard.kde.org/r/113201/diff/
> 
> 
> Testing
> -------
> 
> Testing done on OS X 10.8.5 using Qt 4.8.4 and Ubuntu (to check that the changes don't affect other OSes)
> 
> 
> File Attachments
> ----------------
> 
> Marble Hello World app on OS X
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/10/11/c35469ef-d2ba-4f41-a728-4bdafa85e81f__Screen_Shot_2013-10-11_at_4.55.07_PM.png
> 
> 
> Thanks,
> 
> Mohammed Nafees
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131022/066184e9/attachment.html>