<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113201/">http://git.reviewboard.kde.org/r/113201/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Generally I like the Mac package to become a library that developers can use. I am a bit concerned that the patch introduces another option for it though, which complicates the overcomplicated cmake files even more.
I don't know much about Mac packaging. Is it possible to split up the compilation/installation part and the actual packaging part like done in Linux and Windows? Then just install everything and pick whatever you like for the package that is being created. So I'd suggest not to add a JUSTLIB option, and instead do the "positive" changes it introduces always (e.g. installing headers). And please don't do it by duplicating all of them, just remove the if (APPLE AND QTONLY) check that currently prevents installing headers. For the "negative" changes, i.e. preventing to build applications, I'd argument the same way: Just compile/install them, and do not include them in a library package.
</pre>
<br />
<p>- Dennis Nienhüser</p>
<br />
<p>On October 11th, 2013, 11:26 a.m. UTC, Mohammed Nafees wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Mohammed Nafees.</div>
<p style="color: grey;"><i>Updated Oct. 11, 2013, 11:26 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Previously, using libmarblewidget on OS X was not a very easy task. It had its ups and downs not allowing developers to fully utilise the power of libmarblewidget on OS X. This patch will help developers use libmarblewidget in their OS X apps as well. It has a same structure as in Linux. So, the same code can be compiled on OS X and Linux. This takes Marble a step further into the Mac arena ;)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testing done on OS X 10.8.5 using Qt 4.8.4 and Ubuntu (to check that the changes don't affect other OSes)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/routing-instructions/CMakeLists.txt <span style="color: grey">(531516d)</span></li>
<li>src/mac/Contents/Resources/CMakeLists.txt <span style="color: grey">(3d64414)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(7f54f85)</span></li>
<li>src/lib/CMakeLists.txt <span style="color: grey">(4f2eee1)</span></li>
<li>CMakeLists.txt <span style="color: grey">(a740667)</span></li>
<li>MarbleMacros.cmake <span style="color: grey">(694c4a7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113201/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/11/c35469ef-d2ba-4f41-a728-4bdafa85e81f__Screen_Shot_2013-10-11_at_4.55.07_PM.png">Marble Hello World app on OS X</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>