[Marble-devel] Review Request 113381: ESA SoCIS 2013 - Move SolarSystem 2013 into Marble central place in the esasocis-2012-eclipse branch

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113381/#review42159
-----------------------------------------------------------


I'm glad to see your first review request for ESA SoCiS 2013 :-) . Looks quite nice at first sight. It might have been better to split it into two review requests like mentioned in the task list, but it's ok for now :)

- Torsten Rahn


On Oct. 22, 2013, 10:05 a.m., Marek Hakala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113381/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2013, 10:05 a.m.)
> 
> 
> Review request for Marble, Torsten Rahn and René Küttner.
> 
> 
> Bugs: Feature
>     http://bugs.kde.org/show_bug.cgi?id=Feature
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> ESA SoCIS 2013 - First tasks from Torsten
> ==========================================
> "Personally I think that the following steps would make a good starting point for your ESA SoCiS work:
> 
> 1.) Ideally I would like to see a merge request where the astrolib, attlib, astr2lib and solarsystem get moved into some central place in the marble directory hierarchy. Maybe marble/src/lib/astro/
> 
> 2.) And I would like to see a merge request which makes the existing plugins (satellite, starsplugin and eclipseplugin) make use of these classes in that central place."
> 
> I chose esasocis-2012 branch, because in the master branch is not implemented eclipseplugin. I think the patch meets the requirements from step 1 and 2. Please review my patch for this task steps.
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/satellites/mex/planetarySats.cpp ec31a20 
>   src/plugins/render/satellites/mex/planetarySats.h 0ed34c7 
>   src/plugins/render/satellites/mex/attlib.cpp 0264bd7 
>   src/plugins/render/satellites/mex/astrolib.cpp f1fce2e 
>   src/plugins/render/satellites/mex/attlib.h 7e209cf 
>   src/plugins/render/satellites/mex/astrolib.h 8a878e8 
>   src/plugins/render/satellites/CMakeLists.txt a38a97f 
>   src/plugins/render/eclipses/ecl/eclsolar.cpp e582537 
>   src/plugins/render/eclipses/ecl/attlib.cpp 1dea446 
>   src/plugins/render/eclipses/ecl/eclsolar.h f3fbd72 
>   src/plugins/render/eclipses/ecl/attlib.h 6915008 
>   src/plugins/render/eclipses/ecl/astrolib.cpp a90e2e7 
>   src/plugins/render/eclipses/ecl/astrolib.h 5d5c319 
>   src/plugins/render/eclipses/EclipsesModel.h 3823a6a 
>   src/plugins/render/eclipses/EclipsesModel.cpp 9679b1f 
>   src/plugins/render/eclipses/CMakeLists.txt 551adff 
>   src/lib/astro/solarsystem.cpp PRE-CREATION 
>   src/lib/astro/attlib.cpp PRE-CREATION 
>   src/lib/astro/solarsystem.h PRE-CREATION 
>   src/lib/astro/attlib.h PRE-CREATION 
>   src/lib/astro/astrolib.h PRE-CREATION 
>   src/lib/astro/astrolib.cpp PRE-CREATION 
>   src/lib/astro/astr2lib.cpp PRE-CREATION 
>   src/lib/astro/CMakeLists.txt PRE-CREATION 
>   src/lib/astro/astr2lib.h PRE-CREATION 
>   src/lib/CMakeLists.txt 59ad8d2 
> 
> Diff: http://git.reviewboard.kde.org/r/113381/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marek Hakala
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131022/63144892/attachment.html>