<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113381/">http://git.reviewboard.kde.org/r/113381/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm glad to see your first review request for ESA SoCiS 2013 :-) . Looks quite nice at first sight. It might have been better to split it into two review requests like mentioned in the task list, but it's ok for now :)</pre>
<br />
<p>- Torsten Rahn</p>
<br />
<p>On October 22nd, 2013, 10:05 a.m. UTC, Marek Hakala wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Torsten Rahn and René Küttner.</div>
<div>By Marek Hakala.</div>
<p style="color: grey;"><i>Updated Oct. 22, 2013, 10:05 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=Feature">Feature</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ESA SoCIS 2013 - First tasks from Torsten
==========================================
"Personally I think that the following steps would make a good starting point for your ESA SoCiS work:
1.) Ideally I would like to see a merge request where the astrolib, attlib, astr2lib and solarsystem get moved into some central place in the marble directory hierarchy. Maybe marble/src/lib/astro/
2.) And I would like to see a merge request which makes the existing plugins (satellite, starsplugin and eclipseplugin) make use of these classes in that central place."
I chose esasocis-2012 branch, because in the master branch is not implemented eclipseplugin. I think the patch meets the requirements from step 1 and 2. Please review my patch for this task steps.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/render/satellites/mex/planetarySats.cpp <span style="color: grey">(ec31a20)</span></li>
<li>src/plugins/render/satellites/mex/planetarySats.h <span style="color: grey">(0ed34c7)</span></li>
<li>src/plugins/render/satellites/mex/attlib.cpp <span style="color: grey">(0264bd7)</span></li>
<li>src/plugins/render/satellites/mex/astrolib.cpp <span style="color: grey">(f1fce2e)</span></li>
<li>src/plugins/render/satellites/mex/attlib.h <span style="color: grey">(7e209cf)</span></li>
<li>src/plugins/render/satellites/mex/astrolib.h <span style="color: grey">(8a878e8)</span></li>
<li>src/plugins/render/satellites/CMakeLists.txt <span style="color: grey">(a38a97f)</span></li>
<li>src/plugins/render/eclipses/ecl/eclsolar.cpp <span style="color: grey">(e582537)</span></li>
<li>src/plugins/render/eclipses/ecl/attlib.cpp <span style="color: grey">(1dea446)</span></li>
<li>src/plugins/render/eclipses/ecl/eclsolar.h <span style="color: grey">(f3fbd72)</span></li>
<li>src/plugins/render/eclipses/ecl/attlib.h <span style="color: grey">(6915008)</span></li>
<li>src/plugins/render/eclipses/ecl/astrolib.cpp <span style="color: grey">(a90e2e7)</span></li>
<li>src/plugins/render/eclipses/ecl/astrolib.h <span style="color: grey">(5d5c319)</span></li>
<li>src/plugins/render/eclipses/EclipsesModel.h <span style="color: grey">(3823a6a)</span></li>
<li>src/plugins/render/eclipses/EclipsesModel.cpp <span style="color: grey">(9679b1f)</span></li>
<li>src/plugins/render/eclipses/CMakeLists.txt <span style="color: grey">(551adff)</span></li>
<li>src/lib/astro/solarsystem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/attlib.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/solarsystem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/attlib.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/astrolib.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/astrolib.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/astr2lib.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/astr2lib.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/CMakeLists.txt <span style="color: grey">(59ad8d2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113381/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>