[Marble-devel] Review Request 114031: Added Radio buttons support for the Marble Legend Browser

[Illya Kovalevskyy]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114031/#review44231
-----------------------------------------------------------


Looks good, but I'd like these to be fixed


src/lib/marble/geodata/handlers/dgml/DgmlSectionTagHandler.cpp
<http://git.reviewboard.kde.org/r/114031/#comment31678>

    You should set attribute as it's done with checkboxes (in case of rubbish inside the tag), please.
    
    (line 46)



src/lib/marble/geodata/handlers/dgml/DgmlSectionTagHandler.cpp
<http://git.reviewboard.kde.org/r/114031/#comment31677>

    In my opinion, you should have a check here like it's done with checkboxes (line 57)


- Illya Kovalevskyy


On Nov. 22, 2013, 5:38 p.m., Yazeed Zoabi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114031/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2013, 5:38 p.m.)
> 
> 
> Review request for Marble, Utku Aydın, Dennis Nienhüser, and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> What has basically changed, is that Radio buttons are now implemented in the Marble Legend browser.. you can now add sections (in dgml files) with an Multiple radio buttons (a group of radio buttons) must have the same value for the radio attribute to indicate the group. (a special value for each group) .
> 
> Example of sections that are now shown as radio buttons :
>         <section name="riciolli" radio="RH" checkable="true" connect="riciolli" spacing="12">
>                   <heading><![CDATA[<a href="http://en.wikipedia.org/wiki/Giambattista_Riccioli">Riciolli</a>]]></heading>
>               </section>
>               <section name="hevelius" radio="RH" checkable="true" connect="hevelius" spacing="12">
>                   <heading><![CDATA[<a href="http://en.wikipedia.org/wiki/Johannes_Hevelius">Hevelius</a>]]></heading>
>               </section>
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/MarbleLegendBrowser.h c2a8c62 
>   src/lib/marble/MarbleLegendBrowser.cpp 53524a4 
>   src/lib/marble/geodata/handlers/dgml/DgmlAttributeDictionary.h 2785289 
>   src/lib/marble/geodata/handlers/dgml/DgmlAttributeDictionary.cpp 6940d62 
>   src/lib/marble/geodata/handlers/dgml/DgmlSectionTagHandler.cpp 82aadc9 
>   src/lib/marble/geodata/scene/GeoSceneSection.h 7e60c3c 
>   src/lib/marble/geodata/scene/GeoSceneSection.cpp 8268530 
> 
> Diff: http://git.reviewboard.kde.org/r/114031/diff/
> 
> 
> Testing
> -------
> 
> Testing was done on Kubuntu 13.10 .
> 
> tested the same dgml file with an older marble version (with no radio button implementation), and works fine with checkboxes.
> 
> 
> Thanks,
> 
> Yazeed Zoabi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131122/36383e6d/attachment.html>