<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114031/">http://git.reviewboard.kde.org/r/114031/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, but I'd like these to be fixed</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/114031/diff/1/?file=219184#file219184line48" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/marble/geodata/handlers/dgml/DgmlSectionTagHandler.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">GeoNode* DgmlSectionTagHandler::parse(GeoParser& parser) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">48</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">radio</span> <span class="o">=</span> <span class="n">parser</span><span class="p">.</span><span class="n">attribute</span><span class="p">(</span><span class="n">dgmlAttr_radio</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You should set attribute as it's done with checkboxes (in case of rubbish inside the tag), please.
(line 46)</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/114031/diff/1/?file=219184#file219184line60" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/marble/geodata/handlers/dgml/DgmlSectionTagHandler.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">GeoNode* DgmlSectionTagHandler::parse(GeoParser& parser) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">60</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">section</span><span class="o">-></span><span class="n">setRadio</span><span class="p">(</span> <span class="n">radio</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In my opinion, you should have a check here like it's done with checkboxes (line 57)</pre>
</div>
<br />
<p>- Illya Kovalevskyy</p>
<br />
<p>On November 22nd, 2013, 5:38 p.m. EET, Yazeed Zoabi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Utku Aydın, Dennis Nienhüser, and Torsten Rahn.</div>
<div>By Yazeed Zoabi.</div>
<p style="color: grey;"><i>Updated Nov. 22, 2013, 5:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What has basically changed, is that Radio buttons are now implemented in the Marble Legend browser.. you can now add sections (in dgml files) with an Multiple radio buttons (a group of radio buttons) must have the same value for the radio attribute to indicate the group. (a special value for each group) .
Example of sections that are now shown as radio buttons :
<section name="riciolli" radio="RH" checkable="true" connect="riciolli" spacing="12">
<heading><![CDATA[<a href="http://en.wikipedia.org/wiki/Giambattista_Riccioli">Riciolli</a>]]></heading>
</section>
<section name="hevelius" radio="RH" checkable="true" connect="hevelius" spacing="12">
<heading><![CDATA[<a href="http://en.wikipedia.org/wiki/Johannes_Hevelius">Hevelius</a>]]></heading>
</section>
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testing was done on Kubuntu 13.10 .
tested the same dgml file with an older marble version (with no radio button implementation), and works fine with checkboxes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/MarbleLegendBrowser.h <span style="color: grey">(c2a8c62)</span></li>
<li>src/lib/marble/MarbleLegendBrowser.cpp <span style="color: grey">(53524a4)</span></li>
<li>src/lib/marble/geodata/handlers/dgml/DgmlAttributeDictionary.h <span style="color: grey">(2785289)</span></li>
<li>src/lib/marble/geodata/handlers/dgml/DgmlAttributeDictionary.cpp <span style="color: grey">(6940d62)</span></li>
<li>src/lib/marble/geodata/handlers/dgml/DgmlSectionTagHandler.cpp <span style="color: grey">(82aadc9)</span></li>
<li>src/lib/marble/geodata/scene/GeoSceneSection.h <span style="color: grey">(7e60c3c)</span></li>
<li>src/lib/marble/geodata/scene/GeoSceneSection.cpp <span style="color: grey">(8268530)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114031/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>