[Marble-devel] Review Request 113955: Manual owncloud sync button freezing

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113955/#review44029
-----------------------------------------------------------


Looks good.


src/lib/marble/QtMarbleConfigDialog.h
<http://git.reviewboard.kde.org/r/113955/#comment31568>

    I'd prefer disableSyncNow for consistency



src/lib/marble/QtMarbleConfigDialog.cpp
<http://git.reviewboard.kde.org/r/113955/#comment31569>

    The timer should be disabled here. Otherwise it might interfere with a future click of the user. To make that work, the timer instance (one timer is enough) should become a member variable.
    


- Dennis Nienhüser


On Nov. 19, 2013, 10:53 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113955/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2013, 10:53 p.m.)
> 
> 
> Review request for Marble and Dennis Nienhüser.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> According to Google Code-In 2013 task (http://www.google-melange.com/gci/task/view/google/gci2013/5880683448762368):
> 
> I implemented freezing "Sync now" button, during sync up to 30 sec timeout. It works well, if syncComplete() is emitted right time (what I am not sure abt, because it's too buggy and unstable now).
> 
> 
> Diffs
> -----
> 
>   src/apps/marble-qt/QtMainWindow.cpp 5615f65 
>   src/lib/marble/QtMarbleConfigDialog.h cb4ff01 
>   src/lib/marble/QtMarbleConfigDialog.cpp b32be6e 
>   src/lib/marble/cloudsync/BookmarkSyncManager.cpp 63b17a4 
> 
> Diff: http://git.reviewboard.kde.org/r/113955/diff/
> 
> 
> Testing
> -------
> 
> Works well with normal credentials.
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131120/f268ea04/attachment.html>