[Marble-devel] Review Request 113955: Manual owncloud sync button freezing

Illya Kovalevskyy illya.kovalevskyy at gmail.com
Tue Nov 19 22:53:00 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113955/
-----------------------------------------------------------

Review request for Marble and Dennis Nienhüser.


Repository: marble


Description
-------

According to Google Code-In 2013 task (http://www.google-melange.com/gci/task/view/google/gci2013/5880683448762368):

I implemented freezing "Sync now" button, during sync up to 30 sec timeout. It works well, if syncComplete() is emitted right time (what I am not sure abt, because it's too buggy and unstable now).


Diffs
-----

  src/apps/marble-qt/QtMainWindow.cpp 5615f65 
  src/lib/marble/QtMarbleConfigDialog.h cb4ff01 
  src/lib/marble/QtMarbleConfigDialog.cpp b32be6e 
  src/lib/marble/cloudsync/BookmarkSyncManager.cpp 63b17a4 

Diff: http://git.reviewboard.kde.org/r/113955/diff/


Testing
-------

Works well with normal credentials.


Thanks,

Illya Kovalevskyy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131119/8f410730/attachment.html>


More information about the Marble-devel mailing list