[Marble-devel] Review Request 110637: gx:Tour KML Tag Writer

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110637/#review33137
-----------------------------------------------------------


Can you add a .kml file to src/tests/data/ and add it to src/tests/TestGeoDataWriter.cpp? Then you have a test case (execute tests/TestGeoDataWriter in the build directory) to verify things are working as expected.



src/lib/geodata/writers/kml/KmlPlaylistTagWriter.cpp
<http://git.reviewboard.kde.org/r/110637/#comment24507>

    Just found that we have a KmlFlyToTagWriter already, so we can use writeElement( static_cast<const GeoDataFlyTo*>( primitive ), writer ) here.



src/lib/geodata/writers/kml/KmlPlaylistTagWriter.cpp
<http://git.reviewboard.kde.org/r/110637/#comment24508>

    playMode() is an enum value. Should be something that
    - writes a playMode start element
    - transforms the playMode() enum value to a string and writes it
    - writes a playMode end element
    



src/lib/geodata/writers/kml/KmlTourTagWriter.cpp
<http://git.reviewboard.kde.org/r/110637/#comment24506>

    I'm missing something like
    if ( !tour->id().isEmpty() ) {
      writer.writeAttribute( "id", tour->id() );
    }
    


- Dennis Nienhüser


On May 25, 2013, 5:58 p.m., Adrian Draghici wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110637/
> -----------------------------------------------------------
> 
> (Updated May 25, 2013, 5:58 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Adds support for writing the gx:Tour KML element and its child elements for which the corresponding GeoDataType is already defined.
> 
> 
> Diffs
> -----
> 
>   src/lib/geodata/parser/GeoDataTypes.h c74b3bf 
>   src/lib/geodata/parser/GeoDataTypes.cpp 35cecbd 
>   src/lib/geodata/writers/kml/KmlPlaylistTagWriter.h e69de29 
>   src/lib/geodata/writers/kml/KmlPlaylistTagWriter.cpp e69de29 
>   src/lib/geodata/writers/kml/KmlTourTagWriter.h e69de29 
>   src/lib/geodata/writers/kml/KmlTourTagWriter.cpp e69de29 
> 
> Diff: http://git.reviewboard.kde.org/r/110637/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Adrian Draghici
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130525/8dbd0f40/attachment.html>