<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110637/">http://git.reviewboard.kde.org/r/110637/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can you add a .kml file to src/tests/data/ and add it to src/tests/TestGeoDataWriter.cpp? Then you have a test case (execute tests/TestGeoDataWriter in the build directory) to verify things are working as expected.
</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110637/diff/3/?file=146217#file146217line48" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/geodata/writers/kml/KmlPlaylistTagWriter.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">48</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">writeFlyTo</span><span class="p">(</span> <span class="k">static_cast</span><span class="o"><</span><span class="k">const</span> <span class="n">GeoDataFlyTo</span><span class="o">*></span><span class="p">(</span> <span class="n">primitive</span> <span class="p">),</span> <span class="n">writer</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just found that we have a KmlFlyToTagWriter already, so we can use writeElement( static_cast<const GeoDataFlyTo*>( primitive ), writer ) here.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110637/diff/3/?file=146217#file146217line56" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/geodata/writers/kml/KmlPlaylistTagWriter.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">56</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">writer</span><span class="p">.</span><span class="n">writeElement</span><span class="p">(</span> <span class="n">tourControl</span><span class="o">-></span><span class="n">playMode</span><span class="p">(),</span> <span class="n">writer</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">playMode() is an enum value. Should be something that
- writes a playMode start element
- transforms the playMode() enum value to a string and writes it
- writes a playMode end element
</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110637/diff/3/?file=146219#file146219line31" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/geodata/writers/kml/KmlTourTagWriter.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">31</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm missing something like
if ( !tour->id().isEmpty() ) {
writer.writeAttribute( "id", tour->id() );
}
</pre>
</div>
<br />
<p>- Dennis</p>
<br />
<p>On May 25th, 2013, 5:58 p.m. UTC, Adrian Draghici wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Adrian Draghici.</div>
<p style="color: grey;"><i>Updated May 25, 2013, 5:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds support for writing the gx:Tour KML element and its child elements for which the corresponding GeoDataType is already defined.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/geodata/parser/GeoDataTypes.h <span style="color: grey">(c74b3bf)</span></li>
<li>src/lib/geodata/parser/GeoDataTypes.cpp <span style="color: grey">(35cecbd)</span></li>
<li>src/lib/geodata/writers/kml/KmlPlaylistTagWriter.h <span style="color: grey">(e69de29)</span></li>
<li>src/lib/geodata/writers/kml/KmlPlaylistTagWriter.cpp <span style="color: grey">(e69de29)</span></li>
<li>src/lib/geodata/writers/kml/KmlTourTagWriter.h <span style="color: grey">(e69de29)</span></li>
<li>src/lib/geodata/writers/kml/KmlTourTagWriter.cpp <span style="color: grey">(e69de29)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110637/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>