[Marble-devel] Review Request 110435: Fix #319800: Wrong behaviour of arrows in the Navigation Plugin

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110435/#review32586
-----------------------------------------------------------


The bug mentions two issues:
- spinning continues when moving out of arrow position
- indicator colors are sometimes wrong

The former one could be argued to be a feature as well, assuming it only happens when you move the mouse inside the arrow disc: It allows you to change the rotation direction easily while searching for some place with your eyes. It should not continue however once the disc is left, which currently can happen. Similarly the pressed indicator can stay in its old (now wrong) state when leaving the disc. To fix both I think WidgetGraphicsItem::eventFilter() must create a QEvent::LeaveEvent correctly when the mouse leaves the widget. Currently that is not (always) the case -- e.g. you get a LeaveEvent when moving the mouse from the disc down to the slider cause LeaveEvents are generated correctly between child widgets, but not for the parent widget.


- Dennis Nienhüser


On May 15, 2013, 8:02 a.m., Andrei Duma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110435/
> -----------------------------------------------------------
> 
> (Updated May 15, 2013, 8:02 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> The patch addresses both issues in the bug description.
> 
> There is a case where the patch doesn't fix the first issue: when the user quickly drags the mouse out of the ArrowDiscWidget, the mouse move and button release events are not triggered, thus making it impossible to stop the globe from spinning.
> 
> 
> This addresses bug 319800.
>     http://bugs.kde.org/show_bug.cgi?id=319800
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/navigation/ArrowDiscWidget.h 77e5cdd 
>   src/plugins/render/navigation/ArrowDiscWidget.cpp ee81025 
> 
> Diff: http://git.reviewboard.kde.org/r/110435/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Duma
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130515/dbc4be12/attachment-0001.html>