<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110435/">http://git.reviewboard.kde.org/r/110435/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The bug mentions two issues:
- spinning continues when moving out of arrow position
- indicator colors are sometimes wrong
The former one could be argued to be a feature as well, assuming it only happens when you move the mouse inside the arrow disc: It allows you to change the rotation direction easily while searching for some place with your eyes. It should not continue however once the disc is left, which currently can happen. Similarly the pressed indicator can stay in its old (now wrong) state when leaving the disc. To fix both I think WidgetGraphicsItem::eventFilter() must create a QEvent::LeaveEvent correctly when the mouse leaves the widget. Currently that is not (always) the case -- e.g. you get a LeaveEvent when moving the mouse from the disc down to the slider cause LeaveEvents are generated correctly between child widgets, but not for the parent widget.
</pre>
<br />
<p>- Dennis</p>
<br />
<p>On May 15th, 2013, 8:02 a.m. UTC, Andrei Duma wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Andrei Duma.</div>
<p style="color: grey;"><i>Updated May 15, 2013, 8:02 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch addresses both issues in the bug description.
There is a case where the patch doesn't fix the first issue: when the user quickly drags the mouse out of the ArrowDiscWidget, the mouse move and button release events are not triggered, thus making it impossible to stop the globe from spinning.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=319800">319800</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/render/navigation/ArrowDiscWidget.h <span style="color: grey">(77e5cdd)</span></li>
<li>src/plugins/render/navigation/ArrowDiscWidget.cpp <span style="color: grey">(ee81025)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110435/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>