[Marble-devel] Review Request 110637: gx:Tour KML Tag Writer

[Adrian Draghici]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110637/
-----------------------------------------------------------

(Updated June 6, 2013, 11:30 p.m.)


Review request for Marble.


Changes
-------

Finally fixed the patch, plus I think there was a bug in the GeoDataPlaylist type declaration (not including the header GeoDataFeature.h and extending GeoDataObject instead of GeodataFeature). The problem is that the test fails the saveAndCompare function because it doesn't enter the virtual write function overriden in TourTagWriter (can't figure out why). Any idea on that?


Description
-------

Adds support for writing the gx:Tour KML element and its child elements for which the corresponding GeoDataType is already defined.


Diffs (updated)
-----

  src/lib/geodata/CMakeLists.txt 6638ae3 
  src/lib/geodata/data/GeoDataPlaylist.h f3dd5b9 
  src/lib/geodata/data/GeoDataTour.h b151b44 
  src/lib/geodata/parser/GeoDataTypes.h c74b3bf 
  src/lib/geodata/parser/GeoDataTypes.cpp 35cecbd 
  src/lib/geodata/writers/kml/KmlPlaylistTagWriter.h e69de29 
  src/lib/geodata/writers/kml/KmlPlaylistTagWriter.cpp e69de29 
  src/lib/geodata/writers/kml/KmlTourTagWriter.h e69de29 
  src/lib/geodata/writers/kml/KmlTourTagWriter.cpp e69de29 
  tests/TestGeoDataWriter.cpp 500d092 
  tests/data/Tour.kml e69de29 

Diff: http://git.reviewboard.kde.org/r/110637/diff/


Testing
-------


Thanks,

Adrian Draghici

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130606/50802171/attachment.html>