<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110637/">http://git.reviewboard.kde.org/r/110637/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Adrian Draghici.</div>
<p style="color: grey;"><i>Updated June 6, 2013, 11:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Finally fixed the patch, plus I think there was a bug in the GeoDataPlaylist type declaration (not including the header GeoDataFeature.h and extending GeoDataObject instead of GeodataFeature). The problem is that the test fails the saveAndCompare function because it doesn't enter the virtual write function overriden in TourTagWriter (can't figure out why). Any idea on that?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds support for writing the gx:Tour KML element and its child elements for which the corresponding GeoDataType is already defined.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/geodata/CMakeLists.txt <span style="color: grey">(6638ae3)</span></li>
<li>src/lib/geodata/data/GeoDataPlaylist.h <span style="color: grey">(f3dd5b9)</span></li>
<li>src/lib/geodata/data/GeoDataTour.h <span style="color: grey">(b151b44)</span></li>
<li>src/lib/geodata/parser/GeoDataTypes.h <span style="color: grey">(c74b3bf)</span></li>
<li>src/lib/geodata/parser/GeoDataTypes.cpp <span style="color: grey">(35cecbd)</span></li>
<li>src/lib/geodata/writers/kml/KmlPlaylistTagWriter.h <span style="color: grey">(e69de29)</span></li>
<li>src/lib/geodata/writers/kml/KmlPlaylistTagWriter.cpp <span style="color: grey">(e69de29)</span></li>
<li>src/lib/geodata/writers/kml/KmlTourTagWriter.h <span style="color: grey">(e69de29)</span></li>
<li>src/lib/geodata/writers/kml/KmlTourTagWriter.cpp <span style="color: grey">(e69de29)</span></li>
<li>tests/TestGeoDataWriter.cpp <span style="color: grey">(500d092)</span></li>
<li>tests/data/Tour.kml <span style="color: grey">(e69de29)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110637/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>