[Marble-devel] Review Request 111733: Use generic OS X fullscreen method

[Mohammed Nafees]

> On July 26, 2013, 7:12 p.m., Dennis Nienhüser wrote:
> > src/mac/MarbleMac.mm, line 1
> > <http://git.reviewboard.kde.org/r/111733/diff/3/?file=173901#file173901line1>
> >
> >     why .mm and not .cpp?

because it contains Objective-C code.


> On July 26, 2013, 7:12 p.m., Dennis Nienhüser wrote:
> > src/CMakeLists.txt, line 111
> > <http://git.reviewboard.kde.org/r/111733/diff/3/?file=173898#file173898line111>
> >
> >     Can you move that a bit down and just append mac/MarbleMac.* to the existing lists?

can you elaborate please.


- Mohammed


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111733/#review36566
-----------------------------------------------------------


On July 26, 2013, 6:56 p.m., Mohammed Nafees wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111733/
> -----------------------------------------------------------
> 
> (Updated July 26, 2013, 6:56 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> This patch enables Marble to use the native OS X full screen method/way which makes it more customized for OS X.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt bad9e74 
>   src/CMakeLists.txt b2a3e09 
>   src/QtMainWindow.cpp cda67ce 
>   src/mac/MarbleMac.h PRE-CREATION 
>   src/mac/MarbleMac.mm PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111733/diff/
> 
> 
> Testing
> -------
> 
> Testing done and works!
> 
> 
> Thanks,
> 
> Mohammed Nafees
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130727/8c87ce93/attachment.html>