[Marble-devel] Review Request 111733: Use generic OS X fullscreen method

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111733/#review36566
-----------------------------------------------------------



src/CMakeLists.txt
<http://git.reviewboard.kde.org/r/111733/#comment26971>

    Can you move that a bit down and just append mac/MarbleMac.* to the existing lists?



src/QtMainWindow.cpp
<http://git.reviewboard.kde.org/r/111733/#comment26977>

    Leaks a MarbleMac on each call. What about changing to static methods, see below?
    



src/mac/MarbleMac.h
<http://git.reviewboard.kde.org/r/111733/#comment26975>

    can this method be static?



src/mac/MarbleMac.h
<http://git.reviewboard.kde.org/r/111733/#comment26976>

    can this method also be static?



src/mac/MarbleMac.mm
<http://git.reviewboard.kde.org/r/111733/#comment26974>

    why .mm and not .cpp?



src/mac/MarbleMac.mm
<http://git.reviewboard.kde.org/r/111733/#comment26972>

    Please remove, or change to mDebug



src/mac/MarbleMac.mm
<http://git.reviewboard.kde.org/r/111733/#comment26973>

    Curly brackets also for one-liners, please.


- Dennis Nienhüser


On July 26, 2013, 6:56 p.m., Mohammed Nafees wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111733/
> -----------------------------------------------------------
> 
> (Updated July 26, 2013, 6:56 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> This patch enables Marble to use the native OS X full screen method/way which makes it more customized for OS X.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt bad9e74 
>   src/CMakeLists.txt b2a3e09 
>   src/QtMainWindow.cpp cda67ce 
>   src/mac/MarbleMac.h PRE-CREATION 
>   src/mac/MarbleMac.mm PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111733/diff/
> 
> 
> Testing
> -------
> 
> Testing done and works!
> 
> 
> Thanks,
> 
> Mohammed Nafees
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130726/a07cbcec/attachment-0001.html>