[Marble-devel] Review Request 111499: GroundOverlay Rendering

[Adrian Draghici]

> On July 14, 2013, 8:30 p.m., Thibaut Gridel wrote:
> > src/lib/MergedLayerDecorator.cpp, line 69
> > <http://git.reviewboard.kde.org/r/111499/diff/1/?file=170552#file170552line69>
> >
> >     Why handling this through 2 independent lists?
> >     It seems there is one image per overlay always...

Fixed that, you were right.


> On July 14, 2013, 8:30 p.m., Thibaut Gridel wrote:
> > src/lib/layers/TextureLayer.cpp, line 173
> > <http://git.reviewboard.kde.org/r/111499/diff/1/?file=170557#file170557line173>
> >
> >     Can the overlay be inserted at the right place instead of asking for a full sort immediately?

Did that, though I think for a large number of overlays the sort approach would fare better.


> On July 14, 2013, 8:30 p.m., Thibaut Gridel wrote:
> > src/lib/layers/TextureLayer.cpp, line 103
> > <http://git.reviewboard.kde.org/r/111499/diff/1/?file=170557#file170557line103>
> >
> >     It seemsw this proxy is of little use as you have another sorting afterwards?

Hm. The sorting used afterwards is only for ensuring the drawing in the right order. I thought this one was necessary, isn't it?


- Adrian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111499/#review35943
-----------------------------------------------------------


On July 14, 2013, 9:13 a.m., Adrian Draghici wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111499/
> -----------------------------------------------------------
> 
> (Updated July 14, 2013, 9:13 a.m.)
> 
> 
> Review request for Marble, Bernhard Beschow, Dennis Nienhüser, Torsten Rahn, and Thibaut Gridel.
> 
> 
> Description
> -------
> 
> This patch adds support for rendering GroundOverlays. A model with filtered GroundOverlays is saved in MarbleModel and used in TextureLayer, where the cache of GroundOverlays is handled. The actual rendering takes place in MergedLayerDecorator.
> 
> 
> Diffs
> -----
> 
>   src/lib/MarbleMap.cpp 102ed0d 
>   src/lib/MarbleModel.h 44a5f61 
>   src/lib/MarbleModel.cpp 3c44f9d 
>   src/lib/MergedLayerDecorator.h 2823cfc 
>   src/lib/MergedLayerDecorator.cpp 6363d8e 
>   src/lib/geodata/data/GeoDataGroundOverlay.h 2e144af 
>   src/lib/geodata/data/GeoDataGroundOverlay.cpp 0a87dc4 
>   src/lib/layers/GeometryLayer.cpp 20fd6a7 
>   src/lib/layers/TextureLayer.h 1dbd114 
>   src/lib/layers/TextureLayer.cpp 5b9e9c9 
> 
> Diff: http://git.reviewboard.kde.org/r/111499/diff/
> 
> 
> Testing
> -------
> 
> Tested with multiple overlapping overlays, different rotation angles.
> 
> 
> Thanks,
> 
> Adrian Draghici
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130715/1b8a5dd3/attachment.html>