[Marble-devel] Review Request 111499: GroundOverlay Rendering

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111499/#review35925
-----------------------------------------------------------



src/lib/MergedLayerDecorator.h
<http://git.reviewboard.kde.org/r/111499/#comment26585>

    Can we merge set... and update... into a single method which takes a const ref to a QList as argument? I don't like the sharing and manipulation of the list in two different classes.



src/lib/MergedLayerDecorator.cpp
<http://git.reviewboard.kde.org/r/111499/#comment26586>

    Please use !isEmpty() which is faster and easier to read.



src/lib/MergedLayerDecorator.cpp
<http://git.reviewboard.kde.org/r/111499/#comment26587>

    I'd prefer foreach here.



src/lib/geodata/data/GeoDataGroundOverlay.h
<http://git.reviewboard.kde.org/r/111499/#comment26588>

    Should be const



src/lib/layers/TextureLayer.cpp
<http://git.reviewboard.kde.org/r/111499/#comment26589>

    Please use the normalized signature for connections  (no whitespace)



src/lib/layers/TextureLayer.cpp
<http://git.reviewboard.kde.org/r/111499/#comment26590>

    Is it possible to use just one cast?


- Dennis Nienhüser


On July 14, 2013, 9:13 a.m., Adrian Draghici wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111499/
> -----------------------------------------------------------
> 
> (Updated July 14, 2013, 9:13 a.m.)
> 
> 
> Review request for Marble, Bernhard Beschow, Dennis Nienhüser, Torsten Rahn, and Thibaut Gridel.
> 
> 
> Description
> -------
> 
> This patch adds support for rendering GroundOverlays. A model with filtered GroundOverlays is saved in MarbleModel and used in TextureLayer, where the cache of GroundOverlays is handled. The actual rendering takes place in MergedLayerDecorator.
> 
> 
> Diffs
> -----
> 
>   src/lib/MarbleMap.cpp 102ed0d 
>   src/lib/MarbleModel.h 44a5f61 
>   src/lib/MarbleModel.cpp 3c44f9d 
>   src/lib/MergedLayerDecorator.h 2823cfc 
>   src/lib/MergedLayerDecorator.cpp 6363d8e 
>   src/lib/geodata/data/GeoDataGroundOverlay.h 2e144af 
>   src/lib/geodata/data/GeoDataGroundOverlay.cpp 0a87dc4 
>   src/lib/layers/GeometryLayer.cpp 20fd6a7 
>   src/lib/layers/TextureLayer.h 1dbd114 
>   src/lib/layers/TextureLayer.cpp 5b9e9c9 
> 
> Diff: http://git.reviewboard.kde.org/r/111499/diff/
> 
> 
> Testing
> -------
> 
> Tested with multiple overlapping overlays, different rotation angles.
> 
> 
> Thanks,
> 
> Adrian Draghici
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130714/5de313cb/attachment-0001.html>