[Marble-devel] Review Request 111064: Remove GeoOnfParser

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111064/#review35837
-----------------------------------------------------------


This review has been submitted with commit 25ecfb026f0d594765c357da984965bcb608c380 by Bernhard Beschow to branch master.

- Commit Hook


On June 17, 2013, 11:24 a.m., Bernhard Beschow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111064/
> -----------------------------------------------------------
> 
> (Updated June 17, 2013, 11:24 a.m.)
> 
> 
> Review request for Marble, Jens-Michael Hoffmann and Dennis Nienhüser.
> 
> 
> Description
> -------
> 
> The GeoOnfParser (OpenStreetMap namefinder) is currently unused in Marble and superseeded by the NominatimSearchPlugin. Therefore, remove it.
> 
> 
> Diffs
> -----
> 
>   src/kdemain.cpp 10dfd04efe0a53452c5b7867eed5a195be5aff33 
>   src/lib/geodata/CMakeLists.txt 6638ae30bd5e76448d052d0c58464b0637663b38 
>   src/lib/geodata/handlers/osm-namefinder/AttributeDictionary.h 26a8bd95746c7dc533907d7c2e701a333657b0b2 
>   src/lib/geodata/handlers/osm-namefinder/AttributeDictionary.cpp 059d7a19e53911f15afed7e40272b0977d524f54 
>   src/lib/geodata/handlers/osm-namefinder/DescriptionTagHandler.h d209c9dad5ff113e7ef955cc6a9718f1af6f88f1 
>   src/lib/geodata/handlers/osm-namefinder/DescriptionTagHandler.cpp ddf6e237e6d42c2a2880ac67b82669c17f02a29c 
>   src/lib/geodata/handlers/osm-namefinder/ElementDictionary.h 601c4d240feac843ab4b7a9ca101681894d158b3 
>   src/lib/geodata/handlers/osm-namefinder/ElementDictionary.cpp b26a15bb51ebe3d6fc1b2b0e3f87216e94b60c54 
>   src/lib/geodata/handlers/osm-namefinder/NamedTagHandler.h d269885d43a4c0e859224799e62239365e26a400 
>   src/lib/geodata/handlers/osm-namefinder/NamedTagHandler.cpp 54e8cb79c48b40081a1e6be66e05b5904a0a828e 
>   src/lib/geodata/handlers/osm-namefinder/NearestPlacesTagHandler.h 180fbe6af6e72db12fe05793a653c3751fdc4fdf 
>   src/lib/geodata/handlers/osm-namefinder/NearestPlacesTagHandler.cpp f9ca28b0373d6c08b73fe26b3935ed3e413f0bf9 
>   src/lib/geodata/handlers/osm-namefinder/PlaceTagHandler.h d4c03d27d551513813c9e9498bd3104d57511f31 
>   src/lib/geodata/handlers/osm-namefinder/PlaceTagHandler.cpp 8a645e02df8b112491d512bcdc0029a5742ab38e 
>   src/lib/geodata/handlers/osm-namefinder/SearchResultsTagHandler.h 3dd85ed3f1028698c6dece01f1d365b48d1670fc 
>   src/lib/geodata/handlers/osm-namefinder/SearchResultsTagHandler.cpp 3616b306aaabf4fa8ae6d628d01da03a9dbb32f6 
>   src/lib/geodata/parser/GeoOnfParser.h bcd9f47d7a04e16958f1905511a2321c4c27125f 
>   src/lib/geodata/parser/GeoOnfParser.cpp 1d70392eb9a04b3d71a48e4064ce5a652535eaed 
> 
> Diff: http://git.reviewboard.kde.org/r/111064/diff/
> 
> 
> Testing
> -------
> 
> Do you see any possibility for runtime errors?
> 
> 
> Thanks,
> 
> Bernhard Beschow
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130710/e894d8a7/attachment.html>