<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111064/">http://git.reviewboard.kde.org/r/111064/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 25ecfb026f0d594765c357da984965bcb608c380 by Bernhard Beschow to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On June 17th, 2013, 11:24 a.m. UTC, Bernhard Beschow wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Jens-Michael Hoffmann and Dennis Nienhüser.</div>
<div>By Bernhard Beschow.</div>
<p style="color: grey;"><i>Updated June 17, 2013, 11:24 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The GeoOnfParser (OpenStreetMap namefinder) is currently unused in Marble and superseeded by the NominatimSearchPlugin. Therefore, remove it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do you see any possibility for runtime errors?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kdemain.cpp <span style="color: grey">(10dfd04efe0a53452c5b7867eed5a195be5aff33)</span></li>
<li>src/lib/geodata/CMakeLists.txt <span style="color: grey">(6638ae30bd5e76448d052d0c58464b0637663b38)</span></li>
<li>src/lib/geodata/handlers/osm-namefinder/AttributeDictionary.h <span style="color: grey">(26a8bd95746c7dc533907d7c2e701a333657b0b2)</span></li>
<li>src/lib/geodata/handlers/osm-namefinder/AttributeDictionary.cpp <span style="color: grey">(059d7a19e53911f15afed7e40272b0977d524f54)</span></li>
<li>src/lib/geodata/handlers/osm-namefinder/DescriptionTagHandler.h <span style="color: grey">(d209c9dad5ff113e7ef955cc6a9718f1af6f88f1)</span></li>
<li>src/lib/geodata/handlers/osm-namefinder/DescriptionTagHandler.cpp <span style="color: grey">(ddf6e237e6d42c2a2880ac67b82669c17f02a29c)</span></li>
<li>src/lib/geodata/handlers/osm-namefinder/ElementDictionary.h <span style="color: grey">(601c4d240feac843ab4b7a9ca101681894d158b3)</span></li>
<li>src/lib/geodata/handlers/osm-namefinder/ElementDictionary.cpp <span style="color: grey">(b26a15bb51ebe3d6fc1b2b0e3f87216e94b60c54)</span></li>
<li>src/lib/geodata/handlers/osm-namefinder/NamedTagHandler.h <span style="color: grey">(d269885d43a4c0e859224799e62239365e26a400)</span></li>
<li>src/lib/geodata/handlers/osm-namefinder/NamedTagHandler.cpp <span style="color: grey">(54e8cb79c48b40081a1e6be66e05b5904a0a828e)</span></li>
<li>src/lib/geodata/handlers/osm-namefinder/NearestPlacesTagHandler.h <span style="color: grey">(180fbe6af6e72db12fe05793a653c3751fdc4fdf)</span></li>
<li>src/lib/geodata/handlers/osm-namefinder/NearestPlacesTagHandler.cpp <span style="color: grey">(f9ca28b0373d6c08b73fe26b3935ed3e413f0bf9)</span></li>
<li>src/lib/geodata/handlers/osm-namefinder/PlaceTagHandler.h <span style="color: grey">(d4c03d27d551513813c9e9498bd3104d57511f31)</span></li>
<li>src/lib/geodata/handlers/osm-namefinder/PlaceTagHandler.cpp <span style="color: grey">(8a645e02df8b112491d512bcdc0029a5742ab38e)</span></li>
<li>src/lib/geodata/handlers/osm-namefinder/SearchResultsTagHandler.h <span style="color: grey">(3dd85ed3f1028698c6dece01f1d365b48d1670fc)</span></li>
<li>src/lib/geodata/handlers/osm-namefinder/SearchResultsTagHandler.cpp <span style="color: grey">(3616b306aaabf4fa8ae6d628d01da03a9dbb32f6)</span></li>
<li>src/lib/geodata/parser/GeoOnfParser.h <span style="color: grey">(bcd9f47d7a04e16958f1905511a2321c4c27125f)</span></li>
<li>src/lib/geodata/parser/GeoOnfParser.cpp <span style="color: grey">(1d70392eb9a04b3d71a48e4064ce5a652535eaed)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111064/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>