[Marble-devel] Review Request 108511: Template System + MarbleLegendBrowser + HTML5 (Woo Hoo)

Sun Jan 27 20:37:15 UTC 2013

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108511/
-----------------------------------------------------------

(Updated Jan. 27, 2013, 10:37 p.m.)

Review request for Marble, Dennis Nienhüser, Torsten Rahn, and René Küttner.

Changes
-------

Changes.

Description
-------

A list of changes:

- Fixed Cities bug
- Added TemplateDocument class for templating things
- MarbleLegendBrowser tweaked (support of cool image borders, nice fonts, everything Bootstrap has)
- Added support of Bootstrap (http://twitter.github.com/bootstrap/index.html) in HTML of Marble
- MapInfoDialog improved (see MarbleLegendBrowser changes)

More about TemplateDocument:

- It use %var_name% to template the text
- String format %!{name}% will include library `name` into the HTML. Used in <head> tag

Diffs (updated)
-----

  data/legend.html 317b6cf 
  data/maps/earth/openstreetmap/legend.html aa02426 
  data/maps/earth/openstreetmap/openstreetmap.dgml e4b3c4b 
  data/maps/earth/schagen1689/legend.html db3f171 
  src/lib/CMakeLists.txt 59ad8d2 
  src/lib/MarbleLegendBrowser.cpp fad7020 
  src/lib/MarbleWidgetPopupMenu.cpp eb608be 
  src/lib/TemplateDocument.h PRE-CREATION 
  src/lib/TemplateDocument.cpp PRE-CREATION 
  src/lib/htmlfeatures/bootstrap.inc PRE-CREATION 
  src/lib/htmlfeatures/bootstrap.min.css PRE-CREATION 
  src/lib/libmarble.qrc 7753834 
  src/lib/webpopup/city.html 764f3c3 
  src/lib/webpopup/geoplace.html 4abca92 
  src/lib/webpopup/nation.html 4bfe9a0 
  src/lib/webpopup/placesscreen.css b25f73d 
  src/lib/webpopup/skyplace.html 707f30f 

Diff: http://git.reviewboard.kde.org/r/108511/diff/

Testing
-------

Tested on Qt version of Marble - everything is ok. Tests are passed.

File Attachments
----------------

Old Historic Legend
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/compare-historic-old.png
Old OSM Legend
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/compare-osm-old.png
New Histroric Legend
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/compare-historic-new.png
Old Temperature Legend
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/compare-temp-old.png
New OSM Legend
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/compare-osm-new.png
New Temperature Legend
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/compare-temp-new.png
New MapInfoDialog
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/compare-ukraine-new.png

Thanks,

Illya Kovalevskyy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130127/58652899/attachment.html>