[Marble-devel] Review Request 108511: Template System + MarbleLegendBrowser + HTML5 (Woo Hoo)

Sun Jan 27 16:15:07 UTC 2013

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108511/#review26259
-----------------------------------------------------------

Great work!

src/lib/MarbleLegendBrowser.cpp
<http://git.reviewboard.kde.org/r/108511/#comment19984>

    please remove

src/lib/TemplateDocument.h
<http://git.reviewboard.kde.org/r/108511/#comment19992>

    Please prefix MARBLE_ to avoid collisions when Marble is used as a third-party library

src/lib/TemplateDocument.h
<http://git.reviewboard.kde.org/r/108511/#comment19986>

    Nice :)

src/lib/TemplateDocument.h
<http://git.reviewboard.kde.org/r/108511/#comment19987>

    Why not move this method to TemplateDocumentPrivate?

src/lib/TemplateDocument.cpp
<http://git.reviewboard.kde.org/r/108511/#comment19988>

    else should do something... complain via mDebug at least.

src/lib/TemplateDocument.cpp
<http://git.reviewboard.kde.org/r/108511/#comment19990>

    Isn't that the default behavior of QMaps' [] operator anyway? I think the third line alone is enough.

src/lib/TemplateDocument.cpp
<http://git.reviewboard.kde.org/r/108511/#comment19991>

    Isn't const QString &key possible?

src/lib/webpopup/city.html
<http://git.reviewboard.kde.org/r/108511/#comment19985>

    This ends up unchanged (i.e. as a string) in the popup.

- Dennis Nienhüser

On Jan. 26, 2013, 9:40 a.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108511/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2013, 9:40 a.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser, Torsten Rahn, and René Küttner.
> 
> 
> Description
> -------
> 
> A list of changes:
> 
> - Fixed Cities bug
> - Added TemplateDocument class for templating things
> - MarbleLegendBrowser tweaked (support of cool image borders, nice fonts, everything Bootstrap has)
> - Added support of Bootstrap (http://twitter.github.com/bootstrap/index.html) in HTML of Marble
> - MapInfoDialog improved (see MarbleLegendBrowser changes)
> 
> More about TemplateDocument:
> 
> - It use %var_name% to template the text
> - String format %!{name}% will include library `name` into the HTML. Used in <head> tag
> 
> 
> Diffs
> -----
> 
>   data/legend.html 317b6cf 
>   data/maps/earth/openstreetmap/legend.html aa02426 
>   data/maps/earth/openstreetmap/openstreetmap.dgml e4b3c4b 
>   data/maps/earth/schagen1689/legend.html db3f171 
>   src/lib/CMakeLists.txt 59ad8d2 
>   src/lib/MarbleLegendBrowser.cpp fad7020 
>   src/lib/MarbleWidgetPopupMenu.cpp eb608be 
>   src/lib/TemplateDocument.h PRE-CREATION 
>   src/lib/TemplateDocument.cpp PRE-CREATION 
>   src/lib/htmlfeatures/bootstrap.inc PRE-CREATION 
>   src/lib/htmlfeatures/bootstrap.min.css PRE-CREATION 
>   src/lib/libmarble.qrc 7753834 
>   src/lib/webpopup/city.html 764f3c3 
>   src/lib/webpopup/geoplace.html 4abca92 
>   src/lib/webpopup/nation.html 4bfe9a0 
>   src/lib/webpopup/placesscreen.css b25f73d 
>   src/lib/webpopup/skyplace.html 707f30f 
> 
> Diff: http://git.reviewboard.kde.org/r/108511/diff/
> 
> 
> Testing
> -------
> 
> Tested on Qt version of Marble - everything is ok. Tests are passed.
> 
> 
> File Attachments
> ----------------
> 
> Old Historic Legend
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/compare-historic-old.png
> Old OSM Legend
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/compare-osm-old.png
> New Histroric Legend
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/compare-historic-new.png
> Old Temperature Legend
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/compare-temp-old.png
> New OSM Legend
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/compare-osm-new.png
> New Temperature Legend
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/compare-temp-new.png
> New MapInfoDialog
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/compare-ukraine-new.png
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130127/8fccb508/attachment.html>