[Marble-devel] Review Request: Migrate Satellite Plugin to usage of MapInfoDialog

[Illya Kovalevskyy]

> On Jan. 1, 2013, 1:54 p.m., Illya Kovalevskyy wrote:
> > src/lib/MarbleWidgetPopupMenu.cpp, line 240
> > <http://git.reviewboard.kde.org/r/108061/diff/1/?file=103586#file103586line240>
> >
> >     A problem with coordinates - it returns coordinates full of nulls.
> >     
> >     E.g. the is altitude: 0.00 m and etc.
> >     
> >     Can't fix it now.

Fix is described in diff between r2 and r1 ;)


- Illya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108061/#review24361
-----------------------------------------------------------


On Jan. 1, 2013, 6:56 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108061/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2013, 6:56 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser, Torsten Rahn, and René Küttner.
> 
> 
> Description
> -------
> 
> Satellite Plugin has been migrated to usage of MapInfoDialog successfully according to GCI task:
>  - https://google-melange.appspot.com/gci/task/view/google/gci2012/8093214
> 
> 
> Diffs
> -----
> 
>   src/lib/MarbleWidgetPopupMenu.cpp c258fa7 
>   src/plugins/render/satellites/SatellitesMSCItem.cpp 7292930 
>   src/plugins/render/satellites/SatellitesTLEItem.h 23ecafb 
>   src/plugins/render/satellites/SatellitesTLEItem.cpp 90bb4d1 
>   src/plugins/render/satellites/TrackerPluginItem.h f224981 
>   src/plugins/render/satellites/TrackerPluginItem.cpp 7d3da5c 
>   src/plugins/render/satellites/data/marble_deco_satellite.png PRE-CREATION 
>   src/plugins/render/satellites/data/orbital_elements.png PRE-CREATION 
>   src/plugins/render/satellites/data/satellite.html PRE-CREATION 
>   src/plugins/render/satellites/data/satellitescreen.css PRE-CREATION 
>   src/plugins/render/satellites/satellites.qrc 0ba4d22 
> 
> Diff: http://git.reviewboard.kde.org/r/108061/diff/
> 
> 
> Testing
> -------
> 
> Built & Tested on Linux (Intel) with Qt 4.8.3
> 
> 
> Screenshots
> -----------
> 
> Usecase 1
>   http://git.reviewboard.kde.org/r/108061/s/946/
> Usecase 2
>   http://git.reviewboard.kde.org/r/108061/s/947/
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130101/1d2953b4/attachment-0001.html>