<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108061/">http://git.reviewboard.kde.org/r/108061/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 1st, 2013, 1:54 p.m., <b>Illya Kovalevskyy</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108061/diff/1/?file=103586#file103586line240" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/MarbleWidgetPopupMenu.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void MarbleWidgetPopupMenu::slotInfoDialog()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">240</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">popup</span><span class="o">-></span><span class="n">setCoordinates</span><span class="p">(</span><span class="n">index</span><span class="o">-></span><span class="n">coordinate</span><span class="p">(),</span> <span class="n">Qt</span><span class="o">::</span><span class="n">AlignRight</span> <span class="o">|</span> <span class="n">Qt</span><span class="o">::</span><span class="n">AlignVCenter</span><span class="p">);</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">240</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">popup</span><span class="o">-></span><span class="n">setCoordinates</span><span class="p">(</span><span class="n">index</span><span class="o">-></span><span class="n">coordinate</span><span class="p">(),</span> <span class="n">Qt</span><span class="o">::</span><span class="n">AlignRight</span> <span class="o">|</span> <span class="n">Qt</span><span class="o">::</span><span class="n">AlignVCenter</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A problem with coordinates - it returns coordinates full of nulls.
E.g. the is altitude: 0.00 m and etc.
Can't fix it now.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix is described in diff between r2 and r1 ;)</pre>
<br />
<p>- Illya</p>
<br />
<p>On January 1st, 2013, 6:56 p.m., Illya Kovalevskyy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Dennis Nienhüser, Torsten Rahn, and René Küttner.</div>
<div>By Illya Kovalevskyy.</div>
<p style="color: grey;"><i>Updated Jan. 1, 2013, 6:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Satellite Plugin has been migrated to usage of MapInfoDialog successfully according to GCI task:
- https://google-melange.appspot.com/gci/task/view/google/gci2012/8093214</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built & Tested on Linux (Intel) with Qt 4.8.3</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/MarbleWidgetPopupMenu.cpp <span style="color: grey">(c258fa7)</span></li>
<li>src/plugins/render/satellites/SatellitesMSCItem.cpp <span style="color: grey">(7292930)</span></li>
<li>src/plugins/render/satellites/SatellitesTLEItem.h <span style="color: grey">(23ecafb)</span></li>
<li>src/plugins/render/satellites/SatellitesTLEItem.cpp <span style="color: grey">(90bb4d1)</span></li>
<li>src/plugins/render/satellites/TrackerPluginItem.h <span style="color: grey">(f224981)</span></li>
<li>src/plugins/render/satellites/TrackerPluginItem.cpp <span style="color: grey">(7d3da5c)</span></li>
<li>src/plugins/render/satellites/data/marble_deco_satellite.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/satellites/data/orbital_elements.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/satellites/data/satellite.html <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/satellites/data/satellitescreen.css <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/satellites/satellites.qrc <span style="color: grey">(0ba4d22)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108061/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/108061/s/946/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2013/01/01/bet-lord-1_400x100.png" style="border: 1px black solid;" alt="Usecase 1" /></a>
<a href="http://git.reviewboard.kde.org/r/108061/s/947/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2013/01/01/bet-lord-2_400x100.png" style="border: 1px black solid;" alt="Usecase 2" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>