[Marble-devel] Review Request 108842: create a unique database object for each runner

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108842/#review26973
-----------------------------------------------------------

Ship it!


Looks good to me (didn't test it though).


src/plugins/runner/local-osm-search/OsmDatabase.cpp
<http://git.reviewboard.kde.org/r/108842/#comment20354>

    int should be size_t


- Dennis Nienhüser


On Feb. 7, 2013, 9:10 p.m., Bernhard Beschow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108842/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2013, 9:10 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Fixes crash when another database query is started while an old one is still running.
> 
> 
> Diffs
> -----
> 
>   src/plugins/runner/local-osm-search/LocalOsmSearchPlugin.h 51642f509eb387ae246ee36ecdcbb5ad3d57c6a2 
>   src/plugins/runner/local-osm-search/LocalOsmSearchPlugin.cpp 4b3631553df2b480be443169ce896a9d3e6a0912 
>   src/plugins/runner/local-osm-search/LocalOsmSearchRunner.h c2d58418bbb4c2d69d392a5907e0b7817a8e81af 
>   src/plugins/runner/local-osm-search/LocalOsmSearchRunner.cpp c89dbcb227e8ca5fc6e5b7171443b0009eb72c65 
>   src/plugins/runner/local-osm-search/OsmDatabase.h f2b91ada7f96d8878607c4b3975f724497e353b8 
>   src/plugins/runner/local-osm-search/OsmDatabase.cpp e8e6f5689521674d2643f119a8586d5efdb5ad46 
> 
> Diff: http://git.reviewboard.kde.org/r/108842/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernhard Beschow
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130208/33295715/attachment.html>