<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108842/">http://git.reviewboard.kde.org/r/108842/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me (didn't test it though).</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108842/diff/1/?file=112970#file112970line77" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/runner/local-osm-search/OsmDatabase.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">76</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_database</span> <span class="o">=</span> <span class="n">QSqlDatabase</span><span class="o">::</span><span class="n">addDatabase</span><span class="p">(</span> <span class="s">"QSQLITE"</span><span class="p">,</span> <span class="s">"marble/local-osm-search"</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">77</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_database</span> <span class="o">=</span> <span class="n">QSqlDatabase</span><span class="o">::</span><span class="n">addDatabase</span><span class="p">(</span> <span class="s">"QSQLITE"</span><span class="p">,</span> <span class="n"><span class="hl">QString</span></span><span class="p"><span class="hl">(</span></span><span class="hl"> </span><span class="s">"marble/local-osm-search<span class="hl">-%1</span>"</span> <span class="p">)<span class="hl">.</span></span><span class="n"><span class="hl">arg</span></span><span class="p"><span class="hl">(</span></span><span class="hl"> </span><span class="k"><span class="hl">reinterpret_cast</span></span><span class="o"><span class="hl"><</span></span><span class="kt"><span class="hl">int</span></span><span class="o"><span class="hl">></span></span><span class="p"><span class="hl">(</span></span><span class="hl"> </span><span class="k"><span class="hl">this</span></span><span class="hl"> </span><span class="p"><span class="hl">)</span></span><span class="hl"> </span><span class="p"><span class="hl">)</span></span><span class="hl"> </span><span class="p"><span class="hl">)</span>;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">int should be size_t</pre>
</div>
<br />
<p>- Dennis</p>
<br />
<p>On February 7th, 2013, 9:10 p.m. UTC, Bernhard Beschow wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Bernhard Beschow.</div>
<p style="color: grey;"><i>Updated Feb. 7, 2013, 9:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixes crash when another database query is started while an old one is still running.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/runner/local-osm-search/LocalOsmSearchPlugin.h <span style="color: grey">(51642f509eb387ae246ee36ecdcbb5ad3d57c6a2)</span></li>
<li>src/plugins/runner/local-osm-search/LocalOsmSearchPlugin.cpp <span style="color: grey">(4b3631553df2b480be443169ce896a9d3e6a0912)</span></li>
<li>src/plugins/runner/local-osm-search/LocalOsmSearchRunner.h <span style="color: grey">(c2d58418bbb4c2d69d392a5907e0b7817a8e81af)</span></li>
<li>src/plugins/runner/local-osm-search/LocalOsmSearchRunner.cpp <span style="color: grey">(c89dbcb227e8ca5fc6e5b7171443b0009eb72c65)</span></li>
<li>src/plugins/runner/local-osm-search/OsmDatabase.h <span style="color: grey">(f2b91ada7f96d8878607c4b3975f724497e353b8)</span></li>
<li>src/plugins/runner/local-osm-search/OsmDatabase.cpp <span style="color: grey">(e8e6f5689521674d2643f119a8586d5efdb5ad46)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108842/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>