[Marble-devel] Review Request 114762: Mars and Jupiter added

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114762/#review46513
-----------------------------------------------------------


Can we have the pixmap intialization code inside loadStars() factored out, so that it gets even executed for planets if stars are not displayed? :)

- Torsten Rahn


On Dec. 31, 2013, 3:51 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114762/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2013, 3:51 p.m.)
> 
> 
> Review request for Marble and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> According to Google Code-In 2013 task (http://www.google-melange.com/gci/task/view/google/gci2013/6403420294479872):
> 
> * Mars added to StarsPlugin 
> * Jupiter added to StarsPlugin
> * Refactoring on stars pixmaps done
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/stars/StarsConfigWidget.ui dd7dbfc 
>   src/plugins/render/stars/StarsPlugin.h dd41305 
>   src/plugins/render/stars/StarsPlugin.cpp 4bd3f26 
> 
> Diff: https://git.reviewboard.kde.org/r/114762/diff/
> 
> 
> Testing
> -------
> 
> Tested, verified with KStars
> 
> 
> File Attachments
> ----------------
> 
> Mars
>   https://git.reviewboard.kde.org/media/uploaded/files/2013/12/31/fc892834-c60a-49de-809d-5522a6c4e341__Screen_Shot_2013-12-31_at_5.45.37_PM.png
> Jupiter
>   https://git.reviewboard.kde.org/media/uploaded/files/2013/12/31/8e39f170-0dec-439c-a132-da25ab1b1247__Screen_Shot_2013-12-31_at_5.46.45_PM.png
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131231/03889599/attachment.html>