<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114762/">https://git.reviewboard.kde.org/r/114762/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can we have the pixmap intialization code inside loadStars() factored out, so that it gets even executed for planets if stars are not displayed? :)</pre>
<br />
<p>- Torsten Rahn</p>
<br />
<p>On December 31st, 2013, 3:51 p.m. UTC, Illya Kovalevskyy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble and Torsten Rahn.</div>
<div>By Illya Kovalevskyy.</div>
<p style="color: grey;"><i>Updated Dec. 31, 2013, 3:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">According to Google Code-In 2013 task (http://www.google-melange.com/gci/task/view/google/gci2013/6403420294479872):
* Mars added to StarsPlugin
* Jupiter added to StarsPlugin
* Refactoring on stars pixmaps done</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested, verified with KStars</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/render/stars/StarsConfigWidget.ui <span style="color: grey">(dd7dbfc)</span></li>
<li>src/plugins/render/stars/StarsPlugin.h <span style="color: grey">(dd41305)</span></li>
<li>src/plugins/render/stars/StarsPlugin.cpp <span style="color: grey">(4bd3f26)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114762/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/12/31/fc892834-c60a-49de-809d-5522a6c4e341__Screen_Shot_2013-12-31_at_5.45.37_PM.png">Mars</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/12/31/8e39f170-0dec-439c-a132-da25ab1b1247__Screen_Shot_2013-12-31_at_5.46.45_PM.png">Jupiter</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>