[Marble-devel] Review Request 114722: Moon support: lunar phases

[Illya Kovalevskyy]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114722/
-----------------------------------------------------------

(Updated Dec. 29, 2013, 5 p.m.)


Review request for Marble and Torsten Rahn.


Changes
-------

* Rendering improved


Repository: marble


Description (updated)
-------

According to Google Code-In 2013 task (https://google-melange.appspot.com/gci/task/view/google/gci2013/6453369690390528):

Lunar phases are showing now on the moon pixmap, with opacity 75%

P.S. Screenshots are using the Moon with increased size (in debugging purpose) with yellow pen border.


Diffs (updated)
-----

  src/plugins/render/stars/StarsPlugin.cpp 4bed657 
  data/svg/moon.png 1413065 

Diff: https://git.reviewboard.kde.org/r/114722/diff/


Testing (updated)
-------

All possible phase cases (screenshots), unit-tests.


File Attachments (updated)
----------------

Phase 0.0
  https://git.reviewboard.kde.org/media/uploaded/files/2013/12/29/8f264064-e0c8-4daa-ae1c-f2336e352aa7__Screen_Shot_2013-12-29_at_4.53.30_PM.png
Phase 0.25
  https://git.reviewboard.kde.org/media/uploaded/files/2013/12/29/1a1aad38-b586-422e-9cd2-fd739e6b9a07__Screen_Shot_2013-12-29_at_4.55.03_PM.png
Phase 0.5
  https://git.reviewboard.kde.org/media/uploaded/files/2013/12/29/94510852-26e4-45e0-a1e1-4e50602198c0__Screen_Shot_2013-12-29_at_4.55.20_PM.png
Phase 0.75
  https://git.reviewboard.kde.org/media/uploaded/files/2013/12/29/68ed7797-5ebe-48b8-8e13-8382f479d9b6__Screen_Shot_2013-12-29_at_4.55.38_PM.png
Phase 1.0
  https://git.reviewboard.kde.org/media/uploaded/files/2013/12/29/d1eafb0d-eb9f-417a-83e1-b5da10947a60__Screen_Shot_2013-12-29_at_4.55.58_PM.png


Thanks,

Illya Kovalevskyy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131229/ab8daa3c/attachment.html>