[Marble-devel] Review Request 114722: Moon support: lunar phases

[Illya Kovalevskyy]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114722/
-----------------------------------------------------------

Review request for Marble and Torsten Rahn.


Repository: marble


Description
-------

According to Google Code-In 2013 task (https://google-melange.appspot.com/gci/task/view/google/gci2013/6453369690390528):

Lunar phases are showing now on the moon pixmap, with opacity 75%


Diffs
-----

  src/plugins/render/stars/StarsPlugin.cpp 4bed657 
  data/svg/moon.png 1413065 

Diff: https://git.reviewboard.kde.org/r/114722/diff/


Testing
-------

All possible phase cases, unit-tests.


File Attachments
----------------

Phase: 0.0
  https://git.reviewboard.kde.org/media/uploaded/files/2013/12/29/56922364-2486-4630-92fd-167f309213b3__Screen_Shot_2013-12-29_at_12.03.19_PM.png
Phase: 1.0
  https://git.reviewboard.kde.org/media/uploaded/files/2013/12/29/f9c18752-97b5-47e4-a2d8-67e6f1f8b2e5__Screen_Shot_2013-12-29_at_12.05.26_PM.png
Phase 0.2
  https://git.reviewboard.kde.org/media/uploaded/files/2013/12/29/d49f4cb3-a47b-4530-81ce-82b998ee823e__Screen_Shot_2013-12-29_at_12.05.44_PM.png
Phase 0.5
  https://git.reviewboard.kde.org/media/uploaded/files/2013/12/29/df807dbf-442a-4f57-bf7d-8b0826e5f8f1__Screen_Shot_2013-12-29_at_12.06.01_PM.png
Phase 0.8
  https://git.reviewboard.kde.org/media/uploaded/files/2013/12/29/06e01956-d0f3-4273-ac13-26e7db98c414__Screen_Shot_2013-12-29_at_12.06.22_PM.png


Thanks,

Illya Kovalevskyy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131229/e40b2c64/attachment-0001.html>