[Marble-devel] Review Request 114719: [GCI] Factor constellation names out of star plugin. (1)

[Mihail Ivchenko]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114719/
-----------------------------------------------------------

(Updated Dec. 29, 2013, 2:49 p.m.)


Review request for Marble.


Repository: marble


Description
-------

Factor constellation names out of star plugin.
That's first way to do that.
GCI task: http://www.google-melange.com/gci/task/view/google/gci2013/5233734269796352

Second way: https://git.reviewboard.kde.org/r/114720

That's way takes 15-16 ms for parsing csv (first run) and 5 ms with cached file.

I prefer this way, because csv is easier to edit and speed is not very different.


Diffs (updated)
-----

  src/plugins/render/stars/StarsPlugin.cpp 4bed657 
  data/stars/names.csv PRE-CREATION 
  data/CMakeLists.txt 9ac9620 
  Messages.sh 93fac6b 

Diff: https://git.reviewboard.kde.org/r/114719/diff/


Testing
-------


Thanks,

Mihail Ivchenko

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131229/2b763ff2/attachment.html>