[Marble-devel] Review Request 114719: [GCI] Factor constellation names out of star plugin. (1)

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114719/#review46361
-----------------------------------------------------------



Messages.sh
<https://git.reviewboard.kde.org/r/114719/#comment33069>

    Let's simplify that to
    
    cut -d ',' -f 1 data/stars/names.csv | sed -e 's/^/i18n(/' -e 's/$/);/' >> rc.cpp
    
    (or cut -d ';' ... if you change the separator, see next comment)
    



src/plugins/render/stars/StarsPlugin.cpp
<https://git.reviewboard.kde.org/r/114719/#comment33070>

    Can you use ';' instead as a separator in the .csv file? That's less prone to clashes with real input.
    


- Dennis Nienhüser


On Dec. 29, 2013, 10:34 a.m., Mihail Ivchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114719/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2013, 10:34 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Factor constellation names out of star plugin.
> That's first way to do that.
> GCI task: http://www.google-melange.com/gci/task/view/google/gci2013/5233734269796352
> 
> Second way: https://git.reviewboard.kde.org/r/114720
> 
> That's way takes 15-16 ms for parsing csv (first run) and 5 ms with cached file.
> 
> I prefer this way, because csv is easier to edit and speed is not very different.
> 
> 
> Diffs
> -----
> 
>   Messages.sh 93fac6b 
>   data/CMakeLists.txt 9ac9620 
>   data/stars/names.csv PRE-CREATION 
>   src/plugins/render/stars/StarsPlugin.cpp 4bed657 
> 
> Diff: https://git.reviewboard.kde.org/r/114719/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131229/155963a4/attachment.html>