[Marble-devel] Review Request 113903: ESA SoCIS 2013 - Rebasing esasocis-2012-eclipse branch into master branch fix

[René Küttner]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113903/#review45852
-----------------------------------------------------------


This patch fails since the astro library is not linked.
You may have to additionally specify target_link_libraries(..) at the end of CMakeLists.txt.

I would ship this as soon as this issue has been fixed.

- René Küttner


On Dec. 12, 2013, 2:53 a.m., Marek Hakala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113903/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2013, 2:53 a.m.)
> 
> 
> Review request for Marble, Torsten Rahn and René Küttner.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> ESA SoCIS 2013 - Rebasing esasocis-2012-eclipse branch into master branch fix
> 
> 
> Diffs
> -----
> 
>   src/apps/marble-kde/marble_part.cpp 082ad5ece6ec7de3e0441ed8384b46be8d66ba49 
>   src/apps/marble-kde/marble_part.rc baa36185a9baff66700da4ea919dbe287024ed25 
>   src/apps/marble-qt/QtMainWindow.h 80ae2505d97ecfbb07c6db7ffdb0cd0c369b3eb6 
>   src/apps/marble-qt/QtMainWindow.cpp a7132726e74bb22984b1fd1bd2ebbf3c5d4206d6 
>   src/lib/marble/RenderPlugin.cpp a51b27fe4c71ddc781b5193061c6178d0e9f56c3 
>   src/plugins/render/CMakeLists.txt c62070fe9170277ec522ba05c8420147b8a89a54 
>   src/plugins/render/eclipses/CMakeLists.txt PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesBrowserDialog.h PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesBrowserDialog.cpp PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesBrowserDialog.ui PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesConfigDialog.ui PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesItem.h PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesItem.cpp PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesModel.h PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesModel.cpp PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesPlugin.h PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesPlugin.cpp PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesReminderDialog.ui PRE-CREATION 
>   src/plugins/render/eclipses/eclipses.qrc PRE-CREATION 
>   src/plugins/render/eclipses/res/eclipses.png PRE-CREATION 
>   src/plugins/render/eclipses/res/lunar_partial.png PRE-CREATION 
>   src/plugins/render/eclipses/res/lunar_penumbra.png PRE-CREATION 
>   src/plugins/render/eclipses/res/lunar_total.png PRE-CREATION 
>   src/plugins/render/eclipses/res/solar_annular.png PRE-CREATION 
>   src/plugins/render/eclipses/res/solar_partial.png PRE-CREATION 
>   src/plugins/render/eclipses/res/solar_total.png PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113903/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marek Hakala
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131217/b4d237fb/attachment.html>