<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113903/">http://git.reviewboard.kde.org/r/113903/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch fails since the astro library is not linked.
You may have to additionally specify target_link_libraries(..) at the end of CMakeLists.txt.
I would ship this as soon as this issue has been fixed.</pre>
<br />
<p>- René Küttner</p>
<br />
<p>On December 12th, 2013, 2:53 a.m. UTC, Marek Hakala wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Torsten Rahn and René Küttner.</div>
<div>By Marek Hakala.</div>
<p style="color: grey;"><i>Updated Dec. 12, 2013, 2:53 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ESA SoCIS 2013 - Rebasing esasocis-2012-eclipse branch into master branch fix</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/apps/marble-kde/marble_part.cpp <span style="color: grey">(082ad5ece6ec7de3e0441ed8384b46be8d66ba49)</span></li>
<li>src/apps/marble-kde/marble_part.rc <span style="color: grey">(baa36185a9baff66700da4ea919dbe287024ed25)</span></li>
<li>src/apps/marble-qt/QtMainWindow.h <span style="color: grey">(80ae2505d97ecfbb07c6db7ffdb0cd0c369b3eb6)</span></li>
<li>src/apps/marble-qt/QtMainWindow.cpp <span style="color: grey">(a7132726e74bb22984b1fd1bd2ebbf3c5d4206d6)</span></li>
<li>src/lib/marble/RenderPlugin.cpp <span style="color: grey">(a51b27fe4c71ddc781b5193061c6178d0e9f56c3)</span></li>
<li>src/plugins/render/CMakeLists.txt <span style="color: grey">(c62070fe9170277ec522ba05c8420147b8a89a54)</span></li>
<li>src/plugins/render/eclipses/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/EclipsesBrowserDialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/EclipsesBrowserDialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/EclipsesBrowserDialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/EclipsesConfigDialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/EclipsesItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/EclipsesItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/EclipsesModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/EclipsesModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/EclipsesPlugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/EclipsesPlugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/EclipsesReminderDialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/eclipses.qrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/res/eclipses.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/res/lunar_partial.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/res/lunar_penumbra.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/res/lunar_total.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/res/solar_annular.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/res/solar_partial.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/res/solar_total.png <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113903/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>