[Marble-devel] Review Request 114445: [GCI] Added support for showing journey duration for openrouteservice routing.

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114445/#review45682
-----------------------------------------------------------



src/plugins/runner/openrouteservice/OpenRouteServiceRunner.cpp
<http://git.reviewboard.kde.org/r/114445/#comment32644>

    Can you use spaces between the pipes? Melange ate them by accident in the task description.
    
    "%1 %2 | %3 | OpenRouteService";
    



src/plugins/runner/openrouteservice/OpenRouteServiceRunner.cpp
<http://git.reviewboard.kde.org/r/114445/#comment32643>

    For a correct translation we need to make it slightly more complicated:
    
    QString const hoursString = tr("%n hours", "journey duration, hours part", time.hour());
    QString const minutesString = tr("%n minutes", "journey duration, minutes part", time.minute());
    QString const timeString = time.hours() ? tr("%1, %2", "journey duration, where %1=%n hours and %2=%m minutes") : minutesString;
    
    The reason is that there are different translations based on the value of numbers in certain languages (e.g. for english: n=1 => hour, n>1 => hours)


- Dennis Nienhüser


On Dec. 14, 2013, 2:44 p.m., Mihail Ivchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114445/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2013, 2:44 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> GCI task: http://www.google-melange.com/gci/task/view/google/gci2013/4975184217899008
> 
> 
> Diffs
> -----
> 
>   src/plugins/runner/openrouteservice/OpenRouteServiceRunner.cpp 56af1dc 
> 
> Diff: http://git.reviewboard.kde.org/r/114445/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131214/34926955/attachment.html>