[Marble-devel] Review Request 114170: Basic implementation of movie capturing

[Illya Kovalevskyy]

> On Dec. 2, 2013, 11:39 p.m., Dennis Nienhüser wrote:
> > src/apps/marble-qt/QtMainWindow.cpp, line 1411
> > <http://git.reviewboard.kde.org/r/114170/diff/10/?file=222196#file222196line1411>
> >
> >     curly brackets missing

Acc. to Qt Coding Style it's okay, but it's fine, sure


> On Dec. 2, 2013, 11:39 p.m., Dennis Nienhüser wrote:
> > src/lib/marble/MovieCapture.cpp, line 85
> > <http://git.reviewboard.kde.org/r/114170/diff/10/?file=222201#file222201line85>
> >
> >     qAbs is not needed since you use it when creating the session id already (and none of us will likely experience a negative amount of time to epoch ever ;-))

On my system sometimes it's negative, lol. That's why I am absing it.


> On Dec. 2, 2013, 11:39 p.m., Dennis Nienhüser wrote:
> > src/lib/marble/MovieCaptureDialog.cpp, line 72
> > <http://git.reviewboard.kde.org/r/114170/diff/10/?file=222203#file222203line72>
> >
> >     No colloquial UI strings, please

Sorry?


- Illya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114170/#review45014
-----------------------------------------------------------


On Dec. 2, 2013, 11:22 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114170/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2013, 11:22 p.m.)
> 
> 
> Review request for Marble, Utku Aydın, Dennis Nienhüser, and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> According to Google Code-In 2013 task (http://www.google-melange.com/gci/task/view/google/gci2013/5805119807422464):
> 
> Implementation of timer-based fps marblewidget caster. Current impl saves video file, compiled from bmp files saved in temporary directory with avconv/ffmpeg (avconv is a prior one).
> 
> 
> Diffs
> -----
> 
>   src/apps/marble-qt/QtMainWindow.h 80ae250 
>   src/apps/marble-qt/QtMainWindow.cpp a713272 
>   src/apps/marble-ui/icons/16x16/tool-animator.png PRE-CREATION 
>   src/apps/marble-ui/marble.qrc 5ff3a32 
>   src/lib/marble/CMakeLists.txt 8f2c6eb 
>   src/lib/marble/MovieCapture.h PRE-CREATION 
>   src/lib/marble/MovieCapture.cpp PRE-CREATION 
>   src/lib/marble/MovieCaptureDialog.h PRE-CREATION 
>   src/lib/marble/MovieCaptureDialog.cpp PRE-CREATION 
>   src/lib/marble/MovieCaptureDialog.ui PRE-CREATION 
>   tool-animator.png PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/114170/diff/
> 
> 
> Testing
> -------
> 
> UI/UX, unit-tests
> 
> 
> File Attachments
> ----------------
> 
> WEBM video running
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/12/01/e63d9e9f-71e8-449d-99ee-9a2b422061a4__video.png
> Recording dialog
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/12/02/c31ec1f1-e78a-4e40-bd95-425ac029724a__formats.png
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131204/2ef5e3bc/attachment.html>