[Marble-devel] Review Request 114170: Basic implementation of movie capturing

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114170/#review45014
-----------------------------------------------------------


Works fine :)


src/apps/marble-qt/QtMainWindow.cpp
<http://git.reviewboard.kde.org/r/114170/#comment32183>

    curly brackets missing



src/apps/marble-qt/QtMainWindow.cpp
<http://git.reviewboard.kde.org/r/114170/#comment32194>

    Please pass marbleWidget as parent as well so that the dialog does not get its own task bar entry



src/lib/marble/MovieCapture.h
<http://git.reviewboard.kde.org/r/114170/#comment32185>

    explicit makes no sense with two required arguments. Can be kept though when making parent=0 optional



src/lib/marble/MovieCapture.h
<http://git.reviewboard.kde.org/r/114170/#comment32186>

    private



src/lib/marble/MovieCapture.cpp
<http://git.reviewboard.kde.org/r/114170/#comment32187>

    m_ prefix also for private class members



src/lib/marble/MovieCapture.cpp
<http://git.reviewboard.kde.org/r/114170/#comment32188>

    qAbs is not needed since you use it when creating the session id already (and none of us will likely experience a negative amount of time to epoch ever ;-))



src/lib/marble/MovieCapture.cpp
<http://git.reviewboard.kde.org/r/114170/#comment32189>

    I'd mDebug an exitCode != 0



src/lib/marble/MovieCapture.cpp
<http://git.reviewboard.kde.org/r/114170/#comment32193>

    Ideally also rmdir d->tmpDir



src/lib/marble/MovieCaptureDialog.cpp
<http://git.reviewboard.kde.org/r/114170/#comment32190>

    curly brackets



src/lib/marble/MovieCaptureDialog.cpp
<http://git.reviewboard.kde.org/r/114170/#comment32191>

    No colloquial UI strings, please



src/lib/marble/MovieCaptureDialog.cpp
<http://git.reviewboard.kde.org/r/114170/#comment32192>

    No colloquial UI strings, please


- Dennis Nienhüser


On Dec. 2, 2013, 9:22 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114170/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2013, 9:22 p.m.)
> 
> 
> Review request for Marble, Utku Aydın, Dennis Nienhüser, and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> According to Google Code-In 2013 task (http://www.google-melange.com/gci/task/view/google/gci2013/5805119807422464):
> 
> Implementation of timer-based fps marblewidget caster. Current impl saves video file, compiled from bmp files saved in temporary directory with avconv/ffmpeg (avconv is a prior one).
> 
> 
> Diffs
> -----
> 
>   src/apps/marble-qt/QtMainWindow.h 80ae250 
>   src/apps/marble-qt/QtMainWindow.cpp a713272 
>   src/apps/marble-ui/icons/16x16/tool-animator.png PRE-CREATION 
>   src/apps/marble-ui/marble.qrc 5ff3a32 
>   src/lib/marble/CMakeLists.txt 8f2c6eb 
>   src/lib/marble/MovieCapture.h PRE-CREATION 
>   src/lib/marble/MovieCapture.cpp PRE-CREATION 
>   src/lib/marble/MovieCaptureDialog.h PRE-CREATION 
>   src/lib/marble/MovieCaptureDialog.cpp PRE-CREATION 
>   src/lib/marble/MovieCaptureDialog.ui PRE-CREATION 
>   tool-animator.png PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/114170/diff/
> 
> 
> Testing
> -------
> 
> UI/UX, unit-tests
> 
> 
> File Attachments
> ----------------
> 
> WEBM video running
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/12/01/e63d9e9f-71e8-449d-99ee-9a2b422061a4__video.png
> Recording dialog
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/12/02/c31ec1f1-e78a-4e40-bd95-425ac029724a__formats.png
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131202/b177af10/attachment-0001.html>