[Marble-devel] Review Request 114235: ADDED THE FEATURE OF CHECKBOX-STATE DEPENDENT DESCRIPTIONS TO MAP THEMES

[Yazeed Zoabi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114235/
-----------------------------------------------------------

Review request for Marble, Utku Aydın, Dennis Nienhüser, and Torsten Rahn.


Repository: marble


Description
-------

For each checked checkbox or radio button or selected comboBox option, paragraphs (OR images, or anything you want [as many as you want]) describing it can be added now, when it's selected It shows up, when it's not, it disappears :D

a simple change a map maker should do, in the legend.html file:

<p class="con_hevelius" style="display:none;">Hevelius' telescope could see much more detail than could previous telescopes. He saw mountains on the Moon, for example, and was able to estimate their heights. With his skill at drawing and his attention to detail, he created extremely intricate maps.</p>

<p class="con_riciolli" style="display:none;">Riccioli (Giovanni Battista Riccioli) first published his map of the moon in Almagestum nouum, published in Bologna in 1651. The Riccioli moon map is historically of great importance, as it provides the basis for the system of lunar nomenclature still in use.</p>

these were added to the legend.html file, and the class dev_riciolli and dev_hevelius are the values of the dev_ + 'connect' attribute in the sections of the dgml file: 

	      <section name="riciolli" checkable="true" radio="Ric_Hev" connect="riciolli" spacing="12">
		  <heading>Riciolli</heading>
	      </section>
	      <section name="hevelius" checkable="true" radio="Ric_Hev" connect="hevelius" spacing="12">
		  <heading>Hevelius</heading>
	      </section>

a minor change has been made in the MarbleLegendBrowser.cpp, is to call the Javascript functions. Everything else is done with Javascript written in the legend.html file


Diffs
-----

  src/lib/marble/MarbleLegendBrowser.h e7fb4b5 
  src/lib/marble/MarbleLegendBrowser.cpp 644dd0f 
  src/lib/marble/geodata/handlers/dgml/DgmlAttributeDictionary.h d426e0d 
  src/lib/marble/geodata/handlers/dgml/DgmlAttributeDictionary.cpp 20b0ebe 
  src/lib/marble/geodata/handlers/dgml/DgmlSectionTagHandler.cpp 66ee562 
  src/lib/marble/geodata/scene/GeoSceneSection.h 5224f43 
  src/lib/marble/geodata/scene/GeoSceneSection.cpp 9d7bf77 

Diff: http://git.reviewboard.kde.org/r/114235/diff/


Testing
-------


File Attachments
----------------

legend.html
  http://git.reviewboard.kde.org/media/uploaded/files/2013/12/01/d48db26d-f6f8-4f9f-bf51-c20b78c94f1b__legend.html


Thanks,

Yazeed Zoabi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131201/5df97235/attachment.html>