<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114235/">http://git.reviewboard.kde.org/r/114235/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Utku Aydın, Dennis Nienhüser, and Torsten Rahn.</div>
<div>By Yazeed Zoabi.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For each checked checkbox or radio button or selected comboBox option, paragraphs (OR images, or anything you want [as many as you want]) describing it can be added now, when it's selected It shows up, when it's not, it disappears :D
a simple change a map maker should do, in the legend.html file:
<p class="con_hevelius" style="display:none;">Hevelius' telescope could see much more detail than could previous telescopes. He saw mountains on the Moon, for example, and was able to estimate their heights. With his skill at drawing and his attention to detail, he created extremely intricate maps.</p>
<p class="con_riciolli" style="display:none;">Riccioli (Giovanni Battista Riccioli) first published his map of the moon in Almagestum nouum, published in Bologna in 1651. The Riccioli moon map is historically of great importance, as it provides the basis for the system of lunar nomenclature still in use.</p>
these were added to the legend.html file, and the class dev_riciolli and dev_hevelius are the values of the dev_ + 'connect' attribute in the sections of the dgml file:
<section name="riciolli" checkable="true" radio="Ric_Hev" connect="riciolli" spacing="12">
<heading>Riciolli</heading>
</section>
<section name="hevelius" checkable="true" radio="Ric_Hev" connect="hevelius" spacing="12">
<heading>Hevelius</heading>
</section>
a minor change has been made in the MarbleLegendBrowser.cpp, is to call the Javascript functions. Everything else is done with Javascript written in the legend.html file</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/MarbleLegendBrowser.h <span style="color: grey">(e7fb4b5)</span></li>
<li>src/lib/marble/MarbleLegendBrowser.cpp <span style="color: grey">(644dd0f)</span></li>
<li>src/lib/marble/geodata/handlers/dgml/DgmlAttributeDictionary.h <span style="color: grey">(d426e0d)</span></li>
<li>src/lib/marble/geodata/handlers/dgml/DgmlAttributeDictionary.cpp <span style="color: grey">(20b0ebe)</span></li>
<li>src/lib/marble/geodata/handlers/dgml/DgmlSectionTagHandler.cpp <span style="color: grey">(66ee562)</span></li>
<li>src/lib/marble/geodata/scene/GeoSceneSection.h <span style="color: grey">(5224f43)</span></li>
<li>src/lib/marble/geodata/scene/GeoSceneSection.cpp <span style="color: grey">(9d7bf77)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114235/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/12/01/d48db26d-f6f8-4f9f-bf51-c20b78c94f1b__legend.html">legend.html</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>