[Marble-devel] Review Request 112242: Factor out dedicated executable "marble-mobile" for mobile devices

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112242/#review38669
-----------------------------------------------------------


Looks reasonable to me. Let's see how well maintenance works with this approach in the future.

- Torsten Rahn


On Aug. 24, 2013, 1:45 p.m., Bernhard Beschow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112242/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2013, 1:45 p.m.)
> 
> 
> Review request for Marble and Thomas Jarosch.
> 
> 
> Description
> -------
> 
> Having a dedicated executable for mobile devices should ease maintainance for various reasons:
> 1) handling the smallscreen flag correctly is rather fragile and has lead to regressions in the past
> 2) allows for deeper integration into the system w/o "smart" code (determining network state, screensaver handling, hardware zoom buttons, etc.)
> 
> marble-qt looses the --smallscreen and --nosmallscreen commandline switches.
> 
> Note that, ideally, I'd like to backport this change to the 1.6 branch, so I can release Marble Mobile 1.6 for Maemo5. That's why I propose to push this change before https://git.reviewboard.kde.org/r/112114/.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt dce101b25d7c9f168c761d09e3f641bfcf368924 
>   src/ControlView.cpp 73379cc2b4bd9f834cf00a9f5aa74a89ae8b475e 
>   src/QtMainWindow.h 2fe3e210211c5e2030d9c9fbbb8141f2866bc6b2 
>   src/QtMainWindow.cpp b7c6fe9d6cb75aee2d1d2443bbb42568cd3ae6aa 
>   src/StackableWindow.h  
>   src/StackableWindow.cpp  
>   src/marble-mobile/CMakeLists.txt PRE-CREATION 
>   src/marble-mobile/MobileMainWindow.h PRE-CREATION 
>   src/marble-mobile/MobileMainWindow.cpp PRE-CREATION 
>   src/marble-mobile/main.cpp PRE-CREATION 
>   src/qtmain.cpp dc751906f5881c195e19877618981956df858a1d 
> 
> Diff: http://git.reviewboard.kde.org/r/112242/diff/
> 
> 
> Testing
> -------
> 
> Seems to run as good as current master on the N900, except that the legend widget is no QDockWidget. The Qt-only version seems to be unaffected by this change.
> 
> 
> Thanks,
> 
> Bernhard Beschow
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130826/8e048f8a/attachment.html>