<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112242/">http://git.reviewboard.kde.org/r/112242/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks reasonable to me. Let's see how well maintenance works with this approach in the future.</pre>
<br />
<p>- Torsten</p>
<br />
<p>On August 24th, 2013, 1:45 p.m. UTC, Bernhard Beschow wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble and Thomas Jarosch.</div>
<div>By Bernhard Beschow.</div>
<p style="color: grey;"><i>Updated Aug. 24, 2013, 1:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Having a dedicated executable for mobile devices should ease maintainance for various reasons:
1) handling the smallscreen flag correctly is rather fragile and has lead to regressions in the past
2) allows for deeper integration into the system w/o "smart" code (determining network state, screensaver handling, hardware zoom buttons, etc.)
marble-qt looses the --smallscreen and --nosmallscreen commandline switches.
Note that, ideally, I'd like to backport this change to the 1.6 branch, so I can release Marble Mobile 1.6 for Maemo5. That's why I propose to push this change before https://git.reviewboard.kde.org/r/112114/.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems to run as good as current master on the N900, except that the legend widget is no QDockWidget. The Qt-only version seems to be unaffected by this change.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(dce101b25d7c9f168c761d09e3f641bfcf368924)</span></li>
<li>src/ControlView.cpp <span style="color: grey">(73379cc2b4bd9f834cf00a9f5aa74a89ae8b475e)</span></li>
<li>src/QtMainWindow.h <span style="color: grey">(2fe3e210211c5e2030d9c9fbbb8141f2866bc6b2)</span></li>
<li>src/QtMainWindow.cpp <span style="color: grey">(b7c6fe9d6cb75aee2d1d2443bbb42568cd3ae6aa)</span></li>
<li>src/StackableWindow.h <span style="color: grey">()</span></li>
<li>src/StackableWindow.cpp <span style="color: grey">()</span></li>
<li>src/marble-mobile/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/marble-mobile/MobileMainWindow.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/marble-mobile/MobileMainWindow.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/marble-mobile/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qtmain.cpp <span style="color: grey">(dc751906f5881c195e19877618981956df858a1d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112242/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>