[Marble-devel] Review Request 112160: Navigation panel - Resizeable groovy

Marek Hakala hakala.marek at gmail.com
Fri Aug 23 15:54:00 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112160/
-----------------------------------------------------------

(Updated Aug. 23, 2013, 5:53 p.m.)


Review request for Marble.


Changes
-------

[1] initializeSizeValues() was moved to the private section
[2] The QAction for minimization mode have new text "Minimization Mode"
[3] New code for rendering groove
[4] QAction for minimization is now checkable


Description
-------

This patch adds the navigation panel new functionality with reasizing - minimization and maximization mode. In minimization mode is groovy height set to 40 otherwise is set to 160. It's first step for fully customizeable size of groovy.


This addresses bug Feature.
    http://bugs.kde.org/show_bug.cgi?id=Feature


Diffs (updated)
-----

  src/plugins/render/navigation/NavigationFloatItem.h 5651ba7c727466234b1875ed98d93baa863780df 
  src/plugins/render/navigation/NavigationFloatItem.cpp 1ca9e15e07159899dc4e1e10e81df24c35ac9e0a 
  src/plugins/render/navigation/NavigationSlider.h aacad8cc7a5125ce1b11a52c8e46d95daa7db7ff 
  src/plugins/render/navigation/NavigationSlider.cpp 9457d7abda672ebb814a1f961686b704580d02d3 

Diff: http://git.reviewboard.kde.org/r/112160/diff/


Testing
-------


File Attachments
----------------

navigational_backdrop_center_1px.png
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/20/navigational_backdrop_center_1px.png


Thanks,

Marek Hakala

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130823/8792ba0c/attachment.html>


More information about the Marble-devel mailing list