[Marble-devel] Review Request 112160: Navigation panel - Resizeable groovy

Torsten Rahn tackat at kde.org
Fri Aug 23 10:37:42 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112160/#review38417
-----------------------------------------------------------


Looks like a great start but needs some tweaking still before we can give a "Ship It".

- Torsten Rahn


On Aug. 20, 2013, 10:12 p.m., Marek Hakala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112160/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2013, 10:12 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> This patch adds the navigation panel new functionality with reasizing - minimization and maximization mode. In minimization mode is groovy height set to 40 otherwise is set to 160. It's first step for fully customizeable size of groovy.
> 
> 
> This addresses bug Feature.
>     http://bugs.kde.org/show_bug.cgi?id=Feature
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/navigation/NavigationFloatItem.h 5651ba7c727466234b1875ed98d93baa863780df 
>   src/plugins/render/navigation/NavigationFloatItem.cpp 1ca9e15e07159899dc4e1e10e81df24c35ac9e0a 
>   src/plugins/render/navigation/NavigationSlider.h aacad8cc7a5125ce1b11a52c8e46d95daa7db7ff 
>   src/plugins/render/navigation/NavigationSlider.cpp 9457d7abda672ebb814a1f961686b704580d02d3 
>   src/plugins/render/navigation/navigation.qrc ffb0d27e2684349f07cc11cdfddd88938f074e69 
> 
> Diff: http://git.reviewboard.kde.org/r/112160/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> navigational_backdrop_center_1px.png
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/20/navigational_backdrop_center_1px.png
> 
> 
> Thanks,
> 
> Marek Hakala
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130823/69d5f132/attachment.html>


More information about the Marble-devel mailing list