[Marble-devel] Review Request 111499: GroundOverlay Rendering

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111499/#review36932
-----------------------------------------------------------



src/lib/ImageF.h
<http://git.reviewboard.kde.org/r/111499/#comment27238>

    Please change to a private ctor without implementation. This class is not meant to be instantiated



src/lib/ImageF.h
<http://git.reviewboard.kde.org/r/111499/#comment27237>

    pixelF() will be called quite often. Given that the public version is merely two lines, I'd suggest merging them into one method and change the topLeftPixel parameter to a local variable.



src/lib/ImageF.cpp
<http://git.reviewboard.kde.org/r/111499/#comment27239>

    Please use ctor-style casts instead of c-style casts. (int) x becomes int(x). Or here simply int iX = x; The longer variant is better though as the intent becomes clear (and doesn't lead to compiler warnings).



src/lib/MarbleMath.h
<http://git.reviewboard.kde.org/r/111499/#comment27240>

    @brief should occur just once at the start



src/lib/geodata/data/GeoDataLatLonBox.cpp
<http://git.reviewboard.kde.org/r/111499/#comment27250>

    GeoDataCoordinates => const GeoDataCoordinates &



src/lib/layers/TextureLayer.cpp
<http://git.reviewboard.kde.org/r/111499/#comment27252>

    set* is pretty much reserved for setters which then take an argument, so this method is a bit confusing. I'd suggest renaming it updateGroundOverlays.



src/lib/layers/TextureLayer.cpp
<http://git.reviewboard.kde.org/r/111499/#comment27251>

    curly brackets, please


- Dennis Nienhüser


On Aug. 1, 2013, 2:13 p.m., Adrian Draghici wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111499/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2013, 2:13 p.m.)
> 
> 
> Review request for Marble, Bernhard Beschow, Dennis Nienhüser, Torsten Rahn, and Thibaut Gridel.
> 
> 
> Description
> -------
> 
> This patch adds support for rendering GroundOverlays. A model with filtered GroundOverlays is saved in MarbleModel and used in TextureLayer, where the cache of GroundOverlays is handled. The actual rendering takes place in MergedLayerDecorator.
> 
> 
> Diffs
> -----
> 
>   src/lib/CMakeLists.txt 16c7fab 
>   src/lib/ImageF.h e69de29 
>   src/lib/ImageF.cpp e69de29 
>   src/lib/MarbleMap.cpp 8839ad3 
>   src/lib/MarbleMath.h 0a855bb 
>   src/lib/MarbleModel.h 18b16f3 
>   src/lib/MarbleModel.cpp c3e8827 
>   src/lib/MergedLayerDecorator.h 1bf057e 
>   src/lib/MergedLayerDecorator.cpp b03cca1 
>   src/lib/geodata/data/GeoDataLatLonBox.h b21ff0d 
>   src/lib/geodata/data/GeoDataLatLonBox.cpp 511fca5 
>   src/lib/layers/GeometryLayer.cpp 1bba353 
>   src/lib/layers/TextureLayer.h e89ae0c 
>   src/lib/layers/TextureLayer.cpp 8679fdf 
>   tests/TestGudermannian.cpp e69de29 
>   tests/TestToCircumscribedRectangle.cpp e69de29 
> 
> Diff: http://git.reviewboard.kde.org/r/111499/diff/
> 
> 
> Testing
> -------
> 
> Tested with multiple overlapping overlays, different rotation angles.
> 
> 
> Thanks,
> 
> Adrian Draghici
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130801/976fe6cb/attachment-0001.html>