[Marble-devel] Review Request: Add opencaching.com render plugin

[Anders Lund]

> On Nov. 30, 2012, 9:51 p.m., Martin Engelmann wrote:
> > I got the plugin working without any problems using the current master branch. Since the icons are not part of the diff I replaced them with symlinks to another icon before compiling.
> > 
> > I'm not a experienced developer, but here are my comments: 
> > * Perhaps you could replace the QLabel to display the hint with a textbox. If the hints are quite long, then the dialog will grow instead of a line break.
> > * IIRC marking strings for translation is done by i18n(...) in KDE.
> > 
> > In another application I'm creating I had some trouble parsing the JSON reply of opencaching.com using QScriptEngine and QScriptValue. I used QJSON for that. However, I didn't notice any problems using your plugin.
> > 
> > Thank you for your work so far!

About the hint: probably a good idea, although they tend to be relatively short, there is no known limit afaik.
Strings in marble use tr(), to facilitate the qt-only version, so afaik that is mandatory.
I had no trouble with the json parsing so far, and i scrolled quite a bit around the map. I was asked to not use qjson, to avoid the extra dependency I believe. :)

I will update the diffs later, I am implementing my "easy" improvements atm.


- Anders


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107510/#review22846
-----------------------------------------------------------


On Nov. 29, 2012, 8:51 a.m., Anders Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107510/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2012, 8:51 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Adds a render plugins showing geocaches from opencaching.com on the map.
> 
> Capabilities:
> * shows geocaches on the map, using icons derived from opencaching.com graphics
> * shows a tooltip with the most important data when icons are hovered
> * provides a dialog with details, description, hint and recent logs for each geocache
> * the dialog shows the distance to the cache if available, otherwise the distance to the users home location as known by marble (calculated at the time the dialog is shown)
> 
> Good translation support, ui and known translatable datas from the remote service are marked for translation.
> The plugin is trying to use graphics and colors from the remote service in an unobtrusive way, so that the data is easily recognizable but does not interfer with the application or desktop style.
> 
> Possible future improvements:
> * show geocache tags in graphical form (easy)
> * show opencaching "verifyable" attributes for each cache (easy)
> * allow registering/logging a visit to a cache (requires oauth based login)
> * show users found caches by marking the icons with an emblem or special color (requires oauth based login)
> * update distance data in dialog when it changes (easy)
> * show a "go to" widget with live updated distance/bearing/course
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/opencachingcom/CMakeLists.txt PRE-CREATION 
>   src/plugins/render/opencachingcom/CacheDetailsDialog.ui PRE-CREATION 
>   src/plugins/render/opencachingcom/OpenCachingComItem.h PRE-CREATION 
>   src/plugins/render/opencachingcom/OpenCachingComItem.cpp PRE-CREATION 
>   src/plugins/render/opencachingcom/OpenCachingComModel.h PRE-CREATION 
>   src/plugins/render/opencachingcom/OpenCachingComModel.cpp PRE-CREATION 
>   src/plugins/render/opencachingcom/OpenCachingComPlugin.h PRE-CREATION 
>   src/plugins/render/opencachingcom/OpenCachingComPlugin.cpp PRE-CREATION 
>   src/plugins/render/opencachingcom/multi-cache-m.png PRE-CREATION 
>   src/plugins/render/opencachingcom/multi-cache.png PRE-CREATION 
>   src/plugins/render/opencachingcom/opencachingcom.qrc PRE-CREATION 
>   src/plugins/render/opencachingcom/puzzle-m.png PRE-CREATION 
>   src/plugins/render/opencachingcom/puzzle.png PRE-CREATION 
>   src/plugins/render/opencachingcom/traditional-m.png PRE-CREATION 
>   src/plugins/render/opencachingcom/traditional.png PRE-CREATION 
>   src/plugins/render/opencachingcom/unknown-m.png PRE-CREATION 
>   src/plugins/render/opencachingcom/unknown.png PRE-CREATION 
>   src/plugins/render/opencachingcom/virtual-m.png PRE-CREATION 
>   src/plugins/render/opencachingcom/virtual.png PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107510/diff/
> 
> 
> Testing
> -------
> 
> Builds, compiles and functions
> 
> 
> Screenshots
> -----------
> 
> opencaching.com data and tooltip
>   http://git.reviewboard.kde.org/r/107510/s/858/
> Cache details dialog
>   http://git.reviewboard.kde.org/r/107510/s/859/
> 
> 
> Thanks,
> 
> Anders Lund
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121130/b3f83d89/attachment-0001.html>